[
https://issues.apache.org/jira/browse/CASSANDRA-17500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552317#comment-17552317
]
Andres de la Peña commented on CASSANDRA-17500:
-----------------------------------------------
Looks good to me, +1.
I have left a few formatting nits on [this
commit|https://github.com/adelapena/cassandra/commit/f5ff92ed108c72dc39b373ae87a2ce1104a14842].
They can be incorporated during commit, if you agree with them.
I think we'd also need a final CI round with a repeated run of the new tests,
so we reduce the risk of introducing new flakies. The CircleCI config for that
run can be generated with something like, for example:
{code:java}
.circleci/generate.sh -m \
-e REPEATED_UTEST_TARGET=test \
-e REPEATED_UTEST_COUNT=100 \
-e REPEATED_UTEST_CLASS=Guardrail*ReplicationFactorTest
{code}
> Create Maximum Keyspace Replication Factor Guardrail
> -----------------------------------------------------
>
> Key: CASSANDRA-17500
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17500
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Guardrails
> Reporter: Savni Nagarkar
> Assignee: Savni Nagarkar
> Priority: Normal
> Fix For: 4.x
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> This ticket adds a maximum replication factor guardrail to ensure safety when
> creating or altering key spaces. The replication factor will be applied per
> data center. The ticket was prompted as a user set the replication factor
> equal to the number of nodes in the cluster. The property will be added to
> guardrails to ensure consistency.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
