[ 
https://issues.apache.org/jira/browse/CASSANDRA-15968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558261#comment-17558261
 ] 

David Capwell commented on CASSANDRA-15968:
-------------------------------------------

sorry for the delay, just did my first pass


Overall LGTM, but there are small correctness issues that need to be fixed

> nodetool drain fails in jvm dtest
> ---------------------------------
>
>                 Key: CASSANDRA-15968
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15968
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/dtest/java
>            Reporter: David Capwell
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Drain fails since MessagingService doesn’t expect to be shutdown twice.
> {code}
> Caused by: java.lang.AssertionError
>       at 
> org.apache.cassandra.net.MessagingService.shutdown(MessagingService.java:766)
>       at 
> org.apache.cassandra.distributed.impl.Instance.lambda$parallelRun$28(Instance.java:805)
>       at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>       ... 3 more
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to