[
https://issues.apache.org/jira/browse/CASSANDRA-17650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558703#comment-17558703
]
Ekaterina Dimitrova edited comment on CASSANDRA-17650 at 6/26/22 4:26 PM:
--------------------------------------------------------------------------
The latest version LGTM. The patch fixes the issue with _IntKibibytesBound_ and
_batch_size_fail_threshold._ (I will push a separate ticket and fix on Monday
for {_}IntMebibytesBound{_})
If [~adelapena] doesn't have any additional comments, I believe we can squash
and apply the patch to 4.1 and trunk and run CI on both branches.
For now I rebased and pushed an intermediate version on the current trunk
branch for a sanity check:
[CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=CASSANDRA-17650&filter=all]
{*}EDIT{*}: CI LGTM, we only need to correct the number in _testInvalidValue_
from
2147483647B to 2147483648B - side effect of adding the new method and not using
the saturated cast which was wrong.
was (Author: e.dimitrova):
The latest version LGTM. The patch fixes the issue with _IntKibibytesBound_ and
_batch_size_fail_threshold._ (I will push a separate ticket and fix on Monday
for {_}IntMebibytesBound{_})
If [~adelapena] doesn't have any additional comments, I believe we can squash
and apply the patch to 4.1 and trunk and run CI on both branches.
For now I rebased and pushed an intermediate version on the current trunk
branch for a sanity check:
[CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=CASSANDRA-17650&filter=all]
EDIT: CI LGTM, we only need to correct the number in _testInvalidValue_ from
2147483647B to 2147483648B - side effect of adding the new method and not using
the saturated cast which was wrong.
> Check startup and setter validations for batch_size_fail_threshold
> ------------------------------------------------------------------
>
> Key: CASSANDRA-17650
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17650
> Project: Cassandra
> Issue Type: Task
> Components: Local/Config
> Reporter: Ekaterina Dimitrova
> Assignee: Akin Tekeoglu
> Priority: Low
> Fix For: 4.0.x, 4.1-beta, 4.1.x, 4.x
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> During manual inspection it was noticed that batch_size_warn_threshold goes
> through checkValidForByteConversion, but this is not the case for
> batch_size_fail_threshold.
> This ticket is opened to check whether this is a bug or not.
> If it is confirmed it is a bug it needs to be fixed and the ticket can be
> changed to type bug. It seems that this validation was added as part of
> CASSANDRA-15470 to 4.0+. Maybe we also need it in 3.0 and 3.11?
> CC [~adelapena]
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
