[
https://issues.apache.org/jira/browse/CASSANDRA-17650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17559118#comment-17559118
]
Andres de la Peña commented on CASSANDRA-17650:
-----------------------------------------------
Looks good to me, nothing else to add. I have rebased the patch and applied to
4.1 without conflicts, CI is running:
||PR||CI||
|[4.1|https://github.com/adelapena/cassandra/tree/17650-4.1-review]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1730/workflows/f7d5adcc-f4f0-4c9f-ab9d-a0be4140f58d]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1730/workflows/afa9f339-64e3-4a58-9fbf-b5c05b6a24f1]|
|[trunk|https://github.com/adelapena/cassandra/tree/17650-trunk-review]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1731/workflows/1d855d29-a32d-4056-b5b1-3a8f3ec14ab8]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1731/workflows/b57a5e69-d01d-447f-9de1-bae9110becb1]|
> Check startup and setter validations for batch_size_fail_threshold
> ------------------------------------------------------------------
>
> Key: CASSANDRA-17650
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17650
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
> Reporter: Ekaterina Dimitrova
> Assignee: Akin Tekeoglu
> Priority: Low
> Fix For: 4.1-beta, 4.1.x, 4.x
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> During manual inspection it was noticed that batch_size_warn_threshold goes
> through checkValidForByteConversion, but this is not the case for
> batch_size_fail_threshold.
> This ticket is opened to check whether this is a bug or not.
> If it is confirmed it is a bug it needs to be fixed and the ticket can be
> changed to type bug. It seems that this validation was added as part of
> CASSANDRA-15470 to 4.0+. Maybe we also need it in 3.0 and 3.11?
> CC [~adelapena]
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
