[
https://issues.apache.org/jira/browse/CASSANDRA-16911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561607#comment-17561607
]
Paulo Motta commented on CASSANDRA-16911:
-----------------------------------------
The patch looks mostly good to me, except a few minor cosmetic nit comments
added to the PR (feel free to fix/merge on commit).
The objective of this patch is to remove ephemeral marker but we're also adding
two new things:
1. Add ability to display ephemeral snapshots on {{nodetool listsnapshots}} via
{{--ephemeral}} option.
2. Add new column {{ephemeral}} to {{nodetool listnapshots}}
I like 1 since it filters out ephemeral snapshots from the {{listsnapshots}}
output by default, but I'm not sure about 2 since it may potentially make
{{nodetool listsnapshots}} output too large with too many columns - can you
check this is the case? If so, perhaps we could keep this column out.
I think we're missing one dtest to verify that uncleared ephemeral snapshots
are cleared during startup. It may be tricky to create an ephemeral snapshot,
perpaps we could use byteman to make a snapshot repair *not* clear ephemeral
snapshots to make them survive a node restart?
We should also probably create a new ticket to disallow clearing ephemeral
snapshots via {{nodetool clearsnapshots}} unless a specific option is provided
to avoid conflict with ongoing repairs. WDYT?
> Remove ephemeral snapshot marker file and introduce a flag to SnapshotManifest
> ------------------------------------------------------------------------------
>
> Key: CASSANDRA-16911
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16911
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Snapshots
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.2
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> While creating an ephemeral snapshot, a marker file is created at disk in a
> respective snapshot directory. This is not necessary anymore as we have
> introduced SnapshotManifest in CASSANDRA-16789 so we can move this flag
> there. By putting the information if a snapshot is ephemeral or not into
> SnapshotManifest, we simplify and "clean up" the snapshotting process and
> related codebase.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
