[ https://issues.apache.org/jira/browse/CASSANDRA-17725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571621#comment-17571621 ]
Ekaterina Dimitrova edited comment on CASSANDRA-17725 at 7/26/22 9:14 PM: -------------------------------------------------------------------------- {quote}We could also just not have the old {{nodetool}} commands worry about {{{}MiB{}}}, given there are going to be new methods anyway, where we won't have to round. {quote} We can't really as then the setters will be adding the 2 new entire_sstable* parameters in mebibytes/s and the old two in megabits/s which I bet will be a total mess unfortunately. I did the changes, added a bunch of unit tests. Also took care about compaction_throughput as it was suffering from the same issues even if it was already in mebibytes/s. (nodetool takes it in MiB/s) Further to the setters/getters CompactionStats was also affected from the rounding. The good news are that it was already producing output in bytes so I just had to change the methods to point to the right byte methods to ensure no intermediate non-precise calculation happens in between. This is the new 4.1 [PR|https://github.com/apache/cassandra/pull/1754]. I still haven't squashed with the old commits you already saw, hopefully to make it easier to review this last part. The patch is rather noisy and it adds a lot of unit tests as the devil is in the details with this one. [CI is fully green.|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17725-4.1] was (Author: e.dimitrova): {quote}We could also just not have the old {{nodetool}} commands worry about {{{}MiB{}}}, given there are going to be new methods anyway, where we won't have to round. {quote} We can't really as then the setters will be adding the 2 new entire_sstable* parameters in mebibytes/s and the old two in megabits/s which I bet will be a total mess unfortunately. I did the changes, added a bunch of unit tests. Also took care about compaction_throughput as it was suffering from the same issues even if it was already in mebibytes/s. (nodetool takes it in MiB/s) Further to the setters/getters CompactionStats was also affected from the rounding. The good news are that it was already producing output in bytes so I just had to change the methods to point to the right byte methods to ensure no intermediate non-precise calculation happens in between. This is the new 4.1 [PR|https://github.com/apache/cassandra/pull/1754]. I still haven't squashed with the old commits you already saw, hopefully to make it easier to review this last part. The patch is radar noisy and it adds a lot of unit tests as the devil is in the details with this one. [CI is fully green.|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17725-4.1] > Add a flag for throughput in MiB/s for nodetool setstreamthroughput, > getstreamthroughput, setinterdcstreamthroughput and > getinterdcstreamthroughput > ---------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: CASSANDRA-17725 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17725 > Project: Cassandra > Issue Type: Bug > Components: Tool/nodetool > Reporter: Ekaterina Dimitrova > Assignee: Ekaterina Dimitrova > Priority: Normal > Fix For: 4.1-beta, 4.x > > > As we agreed not to add new JMX methods for the new config on the mailing > list, we need at least new flags for setstreamthroughput and > interdcstreamthroughput for the two 4.0 parameters to be set/get also in MiB, > not only in megabits. > Thus we will have the option either to use the old version for those 2, or to > be able to set/get in MiB all 4 streaming parameters. As of 4.1 supported > units for DataRateSpec are MiB/s, B/s, KiB/s, megabit is only for legacy from > 4.0 - backward compatibility. > To be sure we satisfy the requirements around the latest discussions about > backward compatibility in tools, I will use this ticket also to make a final > pass on the unit changes done, to ensure the probe output is not affected. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org