[ https://issues.apache.org/jira/browse/CASSANDRA-18032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632271#comment-17632271 ]
Andres de la Peña commented on CASSANDRA-18032: ----------------------------------------------- The PR adds that {{set -e}} option and also a check to verify that {{circleci}} is available. As mentioned above, {{circleci}} command is only [needed by the {{-a}} option|https://github.com/apache/cassandra/blob/trunk/.circleci/readme.md#updating-the-config], and [also by {{{}-l{}}}, {{-m}} and {{-h}}|https://github.com/apache/cassandra/blob/trunk/.circleci/readme.md#switching-to-higher-resource-settings]. However, the proposed check doesn't verify which flags are run, so it prevents users from exclusively detecting tests and/or setting environment vars with, for example, {{{}.circleci/generate.sh -e REPEATED_UTESTS_COUNT=10{}}}. I think we should do that check if any of the flags requiring {{circleci}} tool is present. That would be in practice almost identical to using {{set -e}} alone, just replacing the printed message. > When generate.sh fails its rc=0 > ------------------------------- > > Key: CASSANDRA-18032 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18032 > Project: Cassandra > Issue Type: Bug > Components: CI > Reporter: David Capwell > Assignee: Berenguer Blasi > Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x > > > {code} > $ ./generate.sh -a > Generating new config.yml file with low resources and LOWRES/MIDRES/HIGHRES > templates from config-2_1.yml > ./generate.sh: line 171: circleci: command not found > patching file ./config-2_1.yml > Hunk #4 succeeded at 1511 (offset 9 lines). > Hunk #5 succeeded at 1525 (offset 9 lines). > Hunk #6 succeeded at 1540 (offset 9 lines). > Hunk #7 succeeded at 1554 (offset 9 lines). > Hunk #8 succeeded at 1569 (offset 9 lines). > Hunk #9 succeeded at 1583 (offset 9 lines). > Hunk #10 succeeded at 1598 (offset 9 lines). > Hunk #11 succeeded at 1616 (offset 9 lines). > Hunk #12 succeeded at 1631 (offset 9 lines). > Hunk #13 succeeded at 1649 (offset 9 lines). > Hunk #14 succeeded at 1664 (offset 9 lines). > Hunk #15 succeeded at 1682 (offset 9 lines). > Hunk #16 succeeded at 1697 (offset 9 lines). > ./generate.sh: line 177: circleci: command not found > patching file ./config-2_1.yml > ./generate.sh: line 183: circleci: command not found > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org