[
https://issues.apache.org/jira/browse/CASSANDRA-16325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656997#comment-17656997
]
David Capwell edited comment on CASSANDRA-16325 at 1/10/23 10:46 PM:
---------------------------------------------------------------------
bq. I think if we updated the ProgressInfo object to store the delta from the
last time progress was called
That would be a good and welcome change... my patch stores a cache of String ->
Long just so I can compute the delta... if streaming could do this for me then
I can lower the memory of the listener.
bq. The only thought I have about moving the counters into the StreamingSession
class is if there is a feature flag around per-file progress. As a user, I
would still want metrics to report if that flag is enabled.
There is a feature flag to disable the stream stats listener, so it makes
complete sets not to couple it with that listener; I agree.
was (Author: dcapwell):
.bq I think if we updated the ProgressInfo object to store the delta from the
last time progress was called
That would be a good and welcome change... my patch stores a cache of String ->
Long just so I can compute the delta... if streaming could do this for me then
I can lower the memory of the listener.
.bq The only thought I have about moving the counters into the StreamingSession
class is if there is a feature flag around per-file progress. As a user, I
would still want metrics to report if that flag is enabled.
There is a feature flag to disable the stream stats listener, so it makes
complete sets not to couple it with that listener; I agree.
> Update streaming metrics incrementally
> --------------------------------------
>
> Key: CASSANDRA-16325
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16325
> Project: Cassandra
> Issue Type: Improvement
> Components: Observability/Metrics
> Reporter: Paulo Motta
> Assignee: Isaac Reath
> Priority: Normal
> Labels: lhf
> Fix For: 4.2
>
> Time Spent: 10h 10m
> Remaining Estimate: 0h
>
> Currently the inbound and outbound streamed bytes metrics are incremented
> after each file is streamed, what doesn't represent the current number of
> bytes streamed since it can take a long time for a large file to be streamed.
> We should update the metric incrementally as data is streamed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
