[
https://issues.apache.org/jira/browse/CASSANDRA-17561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682042#comment-17682042
]
Stefan Miklosovic edited comment on CASSANDRA-17561 at 1/30/23 12:35 PM:
-------------------------------------------------------------------------
I took the patch of [~marcuse] and rebased it against the current trunk. There
were some conflicts as ParamType introduced custom map in CASSANDRA-17981
otherwise nothing else was needed.
I have put some comments to the original patch and I have fixed them in my PR
(1), the build with multiplexer is running here (2,3).
(1) [https://github.com/apache/cassandra/pull/2119/files]
(2) j8 (in progress)
https://app.circleci.com/pipelines/github/instaclustr/cassandra/1810/workflows/f6cace1b-f1a8-41d3-9c56-3e734d459054
(3) j11 (in progress)
https://app.circleci.com/pipelines/github/instaclustr/cassandra/1810/workflows/e7be2b38-2b50-46ae-b555-f61b392d9fb1
was (Author: smiklosovic):
I took the patch of [~marcuse] and rebased it against the current trunk. There
were some conflicts as ParamType introduced custom map in CASSANDRA-17981
otherwise nothing else was needed.
I have put some comments to original the patch and I have fixed them in my PR
(1), the build with multiplexer is running here (2,3).
(1) [https://github.com/apache/cassandra/pull/2119/files]
(2) j8 (in progress)
https://app.circleci.com/pipelines/github/instaclustr/cassandra/1810/workflows/f6cace1b-f1a8-41d3-9c56-3e734d459054
(3) j11 (in progress)
https://app.circleci.com/pipelines/github/instaclustr/cassandra/1810/workflows/e7be2b38-2b50-46ae-b555-f61b392d9fb1
> Diagnostic snapshot service should only snapshot mismatching ranges on
> preview repair mismatch
> ----------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-17561
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17561
> Project: Cassandra
> Issue Type: Improvement
> Components: Consistency/Repair
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Normal
> Fix For: 4.x
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> We currently snapshot all sstables in a table when a preview repair mismatch
> occurs, we should only snapshot the sstables containing the mismatching ranges
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
