[ https://issues.apache.org/jira/browse/CASSANDRA-18223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684824#comment-17684824 ]
Caleb Rackliffe edited comment on CASSANDRA-18223 at 2/16/23 11:20 PM: ----------------------------------------------------------------------- Once the sub-module is in place, I think the easiest way to fix this is going to be adding the following to {{byteman_validate}}: {noformat} if os.path.exists(os.path.join(cdir, 'modules', 'accord')): jars.append(glob.glob(os.path.join(cdir, 'modules', 'accord', 'accord-core', 'build', 'libs', 'accord-core-[0-9].[0-9]-SNAPSHOT.jar'))[0]) {noformat} CC [~dcapwell] was (Author: maedhroz): Once the sub-module is in place, I think the easiest way to fix this is going to be adding the following to {{byteman_validate}}: {noformat} if os.path.exists(os.path.join(cdir, 'accordz')): jars.append(glob.glob(os.path.join(cdir, 'accord', 'accord-core', 'build', 'libs', 'accord-core-[0-9].[0-9]-SNAPSHOT.jar'))[0]) {noformat} CC [~dcapwell] > Byteman rule in stop_data_reads.btm cannot compile against > accord.messages.ReplyContext > --------------------------------------------------------------------------------------- > > Key: CASSANDRA-18223 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18223 > Project: Cassandra > Issue Type: Bug > Components: Accord > Reporter: Caleb Rackliffe > Assignee: Caleb Rackliffe > Priority: Normal > Labels: byteman, dtest, python > Fix For: NA > > > The Python {{read_repair_test}} relies on a Byteman rule on the {{doVerb()}} > method in {{ReadCommandVerbHandler}}, but {{accord.messages.ReplyContext}} > isn’t on the classpath. This is probably because we don't include it in the > list of jars created in {{byteman_validate}}. > {noformat} > AssertionError: byteman script didn't compile > Checking rule disable data reads against class > org.apache.cassandra.db.ReadCommandVerbHandler > Parsed rule "disable data reads" for class > org.apache.cassandra.db.ReadCommandVerbHandler > ERROR : Failed to check rule "disable data reads" loaded from > /home/cassandra/cassandra-dtest/byteman/read_repair/stop_data_reads.btm line > 8 against method doVerb(org.apache.cassandra.net.Message) void > java.lang.NoClassDefFoundError: accord/messages/ReplyContext > {noformat} > ex. > https://app.circleci.com/pipelines/github/maedhroz/cassandra/686/workflows/ffd1e528-b8ec-4534-a333-ab450e110e89/jobs/6481/tests#failed-test-0 > It might make sense to fix this after CASSANDRA-18204 wraps up, so we know > exactly how the Accord library is pulled into C*. Then, once we do fix it, we > should fix in a way that still works w/ 4.0 and 4.1, etc. (i.e. Don't assume > the Accord library must be present.) -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org