[ https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690581#comment-17690581 ]
Ekaterina Dimitrova edited comment on CASSANDRA-18106 at 2/17/23 8:39 PM: -------------------------------------------------------------------------- {quote}{quote}+1 {quote}{quote} I am lost considering our earlier conversation. +1 on the approach or +1 to commit? My understanding is the current patch will break Java 8 Python tests with trunk. So I am +1 on the patch but please, but not on commit/retag yet as this will break trunk. Thank you was (Author: e.dimitrova): {quote}bq. +1 {quote} I am lost considering our earlier conversation. +1 on the approach or +1 to commit? My understanding is the current patch will break Java 8 Python tests. So I am +1 on the patch but please, but not on commit/retag yet as this will break trunk. Thank you > Update CCM for JDK17 and revise current JDK detection strategy > -------------------------------------------------------------- > > Key: CASSANDRA-18106 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18106 > Project: Cassandra > Issue Type: Task > Components: CI > Reporter: Ekaterina Dimitrova > Assignee: Brandon Williams > Priority: Normal > Fix For: 4.x > > > As part of CASSANDRA-16895 initial POC an initial version of CCM patch was > created. This needs to be revisited and reviewed > Recently we closed CASSANDRA-18039 which brought questions, probably we need > to revise how we detect JDK versions in CCM and whether it is correct. To the > best of my knowledge there are certain tests in the repo around that and they > pass so my guess is we need to revise just the strategy and maybe document it > explicitly or consider if we want any changes to be applied. Also, we need to > be careful with breaking changes. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org