[ https://issues.apache.org/jira/browse/CASSANDRA-18258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693374#comment-17693374 ]
Ekaterina Dimitrova edited comment on CASSANDRA-18258 at 2/24/23 11:24 PM: --------------------------------------------------------------------------- Thank you for the quick response. {code:java} I appreciate this is raised a bit late, removing the explicit versions in other files can happen in separate tickets. 18133 will do it for the test scripts. {code} This is a valid question that I would have addressed here in the way you do it in 18133 but I think we should do it when we remove 8 as a whole because currently we do not look only for 1.8 we check [here|https://github.com/apache/cassandra/blob/trunk/bin/cassandra.in.sh#L119-L129] also the patch version. was (Author: e.dimitrova): Thank you for the quick response. {code:java} I appreciate this is raised a bit late, removing the explicit versions in other files can happen in separate tickets. 18133 will do it for the test scripts. {code} This is a valid question that I would have addressed here in the way you do it but I think we should do it when we remove 8 as a whole because currently we do not look only for 1.8 we check [here|https://github.com/apache/cassandra/blob/trunk/bin/cassandra.in.sh#L119-L129] also the patch version. > Add test conf for JDK17 > ----------------------- > > Key: CASSANDRA-18258 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18258 > Project: Cassandra > Issue Type: Task > Components: Local/Config > Reporter: Ekaterina Dimitrova > Assignee: Ekaterina Dimitrova > Priority: Normal > Fix For: 4.x > > > Post CASSANDRA-18252 and CASSANDRA-18179 we will be able to compile current > trunk with JDK17 but in order to start Cassandra and test it we will need > also our conf files updated with some preliminary conf for test purposes. > This ticket will be used to add those to current trunk -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org