[
https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694206#comment-17694206
]
Ekaterina Dimitrova edited comment on CASSANDRA-18106 at 2/27/23 10:27 PM:
---------------------------------------------------------------------------
That is weird.... we had before that issue around not updating the branch on a
second run.
The issue you see now is different and also I can see it installed your branch
>From Configure Virtual Environment and Python dependencies:
-e
git+[https://github.com/driftx/ccm.git@14f2434e94b39dd51032f88e90e054c1b89ff6e3#egg=ccm]
Obtaining ccm from
git+https://github.com/driftx/ccm.git@CASSANDRA-18106#egg=ccm (from -r
/home/cassandra/cassandra-dtest/requirements.txt (line 13))
Cloning https://github.com/driftx/ccm.git (to revision CASSANDRA-18106) to
./env3.6/src/ccm
Running command git clone --filter=blob:none -q
https://github.com/driftx/ccm.git /home/cassandra/env3.6/src/ccm
Running command git checkout -b CASSANDRA-18106 --track origin/CASSANDRA-18106
Switched to a new branch 'CASSANDRA-18106'
Branch 'CASSANDRA-18106' set up to track remote branch 'CASSANDRA-18106' from
'origin'.
Resolved https://github.com/driftx/ccm.git to commit
14f2434e94b39dd51032f88e90e054c1b89ff6e3
Preparing metadata (setup.py) ... - \ done
I assume it is not CASSANDRA-18258 as your previous run that failed that way
was when CASSANDRA-18258 it was still not committed.
was (Author: e.dimitrova):
That is weird.... we had before that issue around not updating the branch on a
second run.
The issue you see now is different and also I can see it installed your branch
>From Configure Virtual Environment and Python dependencies:
-e
git+https://github.com/driftx/ccm.git@14f2434e94b39dd51032f88e90e054c1b89ff6e3#egg=ccm
I assume it is not CASSANDRA-18258 as your previous run that failed that way
was when CASSANDRA-18258 it was still not committed.
> Update CCM for JDK17 and revise current JDK detection strategy
> --------------------------------------------------------------
>
> Key: CASSANDRA-18106
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18106
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Ekaterina Dimitrova
> Assignee: Brandon Williams
> Priority: Normal
> Fix For: 4.x
>
>
> As part of CASSANDRA-16895 initial POC an initial version of CCM patch was
> created. This needs to be revisited and reviewed
> Recently we closed CASSANDRA-18039 which brought questions, probably we need
> to revise how we detect JDK versions in CCM and whether it is correct. To the
> best of my knowledge there are certain tests in the repo around that and they
> pass so my guess is we need to revise just the strategy and maybe document it
> explicitly or consider if we want any changes to be applied. Also, we need to
> be careful with breaking changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
