[
https://issues.apache.org/jira/browse/CASSANDRA-18124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17699145#comment-17699145
]
Maulin Vasavada edited comment on CASSANDRA-18124 at 3/11/23 1:18 AM:
----------------------------------------------------------------------
So far it looks like 1st option is more convoluted. 2nd option is much cleaner
and simple changes. If we fail to provide `keystore_password` for the JKS, it
will fail with the new changes (throws NPE since the
FileBasedSslContextFactory.java doesn't expect null for the password). I can
add validation in the FileBasedSslContextFactory for the null keystore password
to avoid NPE.
was (Author: maulin.vasavada):
So far it looks like 1st option is more convoluted. 2nd option is much cleaner
and simple changes. If we fail to provide `keystore_password` for the JKS, it
will fail with the new changes (throws NPE since the
FileBasedSslContextFactory.java) doesn't expect null for the password. I can
add validation in the FileBasedSslContextFactory for the null keystore password
to avoid NPE.
> Config parameter keystore_password should be nullable
> -----------------------------------------------------
>
> Key: CASSANDRA-18124
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18124
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Config
> Reporter: Tibor Repasi
> Assignee: Maulin Vasavada
> Priority: Normal
> Fix For: 4.1.x, 5.x
>
>
> Some SSL configuration may pass unencrypted private keys. PEMReader might
> accept that by assuming keyPassword to be null in that case (e.g.
> https://github.com/apache/cassandra/blob/f9e033f519c14596da4dc954875756a69aea4e78/src/java/org/apache/cassandra/security/PEMReader.java#L103).
> Current configuration reader does not accept keystore_password parameter to
> be set null or empty in the cassandra.yaml.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
