[ 
https://issues.apache.org/jira/browse/CASSANDRA-18343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703370#comment-17703370
 ] 

Ekaterina Dimitrova commented on CASSANDRA-18343:
-------------------------------------------------

The test fails because of this:

 
{code:java}
bin/nodetool sjk hh
java.lang.RuntimeException: java.util.concurrent.ExecutionException: 
java.lang.IllegalAccessError: class 
org.gridkit.lab.jvm.attach.AttachManager$AttachManagerInt$VMWarpper (in unnamed 
module @0x6c779568) cannot access class sun.tools.attach.HotSpotVirtualMachine 
(in module jdk.attach) because module jdk.attach does not export 
sun.tools.attach to unnamed module @0x6c779568
{code}
>From what I tested it seems this is the only sjk command that hits the issue. 
>jvm-attach-api is already on latest 1.5 version and it seems that one was not 
>updated since 2019. 

Adding below export to jvm17-clients.options solves the problem, I will send 
mail to dev ML prior running CI:
{code:java}
--add-exports jdk.attach/sun.tools.attach=ALL-UNNAMED{code}
 

> JDK17 - fix nodetool_test.TestNodetool.test_sjk
> -----------------------------------------------
>
>                 Key: CASSANDRA-18343
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18343
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CI
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 5.x
>
>
>  
> [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2321/workflows/de1f521d-c5cb-4ddd-bc45-9ec71b577bf3/jobs/19923/tests]
>  
> {code:java}
> AssertionError: Expected 'SJK hh' output assert False == True self = 
> <nodetool_test.TestNodetool object at 0x7f9ab6d95908> @since('4.0') def 
> test_sjk(self): """ Verify that SJK generally works. """ cluster = 
> self.cluster cluster.populate([1]).start() node = cluster.nodelist()[0] out, 
> err, _ = node.nodetool('sjk --help') logger.debug(out) hasPattern = False for 
> line in out.split(os.linesep): if " ttop [Thread Top] Displays threads from 
> JVM process" == line: hasPattern = True assert hasPattern == True, "Expected 
> help about SJK ttop" out, err, _ = node.nodetool('sjk') logger.debug(out) 
> hasPattern = False for line in out.split(os.linesep): if " ttop [Thread Top] 
> Displays threads from JVM process" == line: hasPattern = True assert 
> hasPattern == True, "Expected help about SJK ttop" out, err, _ = 
> node.nodetool('sjk hh -n 10 --live') logger.debug(out) hasPattern = False for 
> line in out.split(os.linesep): if re.match('.*Instances.*Bytes.*Type.*', 
> line): hasPattern = True > assert hasPattern == True, "Expected 'SJK hh' 
> output" E AssertionError: Expected 'SJK hh' output E assert False == True 
> nodetool_test.py:482: AssertionError{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to