[ https://issues.apache.org/jira/browse/CASSANDRA-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17704391#comment-17704391 ]
David Capwell commented on CASSANDRA-17199: ------------------------------------------- Starting commit CI Results (pending): ||Branch||Source||Circle CI||Jenkins|| |trunk|[branch|https://github.com/dcapwell/cassandra/tree/commit_remote_branch/CASSANDRA-17199-trunk-8BBA53CB-6811-48B5-A8DA-96F9B31E57F7]|[build|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-17199-trunk-8BBA53CB-6811-48B5-A8DA-96F9B31E57F7]|[build|unknown]| > Provide summary of failed SessionInfo's in StreamResultFuture > ------------------------------------------------------------- > > Key: CASSANDRA-17199 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17199 > Project: Cassandra > Issue Type: Improvement > Components: Observability/Logging > Reporter: Brendan Cicchi > Assignee: Natnael Adere > Priority: Normal > Labels: AdventCalendar2021, lhf > Fix For: 5.x > > > Currently, we warn about the presence of one or more failed sessions existing > in the final state and then an operator/user traces back through the logs to > find any failed streams for troubleshooting. > {code:java} > private synchronized void maybeComplete() > { > if (finishedAllSessions()) > { > StreamState finalState = getCurrentState(); > if (finalState.hasFailedSession()) > { > logger.warn("[Stream #{}] Stream failed", planId); > tryFailure(new StreamException(finalState, "Stream failed")); > } > else > { > logger.info("[Stream #{}] All sessions completed", planId); > trySuccess(finalState); > } > } > } {code} > It would be helpful to log out a summary of the SessionInfo for each failed > session since that should be accessible via the StreamState. > > This can be especially helpful for longer streaming operations like bootstrap > where the failure could have been a long time back and all recent streams > leading up to the warning actually are successful. > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org