[ https://issues.apache.org/jira/browse/CASSANDRA-18153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707622#comment-17707622 ]
Michael Semb Wever commented on CASSANDRA-18153: ------------------------------------------------ [~jlewandowski], the commit in trunk to CHANGES.txt is incorrect. In trunk there are no "Merge from…" sections. The change should go under the 4.1.2 section (and nothing under 5.0). When the first 5.0 release happens it is presumed (and understood) that all 4.1.x changes found in that same CHANGES.txt file are included. ref: https://github.com/apache/cassandra/commit/e07b8dfe8dc142356223e71e438c77ffe97140c1#diff-59130575b4fb2932c957db2922977d7d89afb0b2085357db1a14615a2fcad776R127-R131 There was a recent discussion in slack to clarify this common misunderstanding (and tribal knowledge). ref: https://the-asf.slack.com/archives/CK23JSY2K/p1679496071133719 ninja fix has been committed: https://github.com/apache/cassandra/commit/4effa4efbe456d2f5335ef4b6db39804eab21042 Also, why are there two "Merge branch 'cassandra-4.0' into cassandra-4.1" commits (14936d0bd3716ed251e799a264f5ab16d51b893b[|https://github.com/apache/cassandra/commit/14936d0bd3716ed251e799a264f5ab16d51b893b] and [f8dd1931eeacb290af9e246376468f3704891cc4|https://github.com/apache/cassandra/commit/f8dd1931eeacb290af9e246376468f3704891cc4])? > Memtable being flushed without hostId in version "me" and newer during > CommitLogReplay > -------------------------------------------------------------------------------------- > > Key: CASSANDRA-18153 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18153 > Project: Cassandra > Issue Type: Bug > Components: Local/SSTable > Reporter: Adriano Bonacin > Assignee: Adriano Bonacin > Priority: Normal > Fix For: 3.0.29, 3.11.15, 4.0.9, 5.0, 4.1.2 > > Time Spent: 2h > Remaining Estimate: 0h > > On ticket CASSANDRA-16619 some files were changed to allow Cassandra to store > HostID in the new "me" SSTable version. > But SSTables flushed during CommitLogReplay miss this HostID info. > > In the next Cassandra startup, if these SSTables were still present, > system.log will show: > {{WARN Origin of 3 sstables is unknown or doesn't match the local node; > commitLogIntervals for them were ignored}} > {{WARN }}{{{}Origin of 3 sstables is unknown or doesn't match the local node; > commitLogIntervals for them were ignored{}}}{{{}{}}}{{ }} > > And debug.log will show a list of SSTables, witch can include "md" and "me" > version (before upgradesstables): > > {{Ignored commitLogIntervals from the following sstables: > [/var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/me-3-big-Data.db, > > /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-1-big-Data.db, > > /var/lib/cassandra/data/system/compaction_history-b4dbb7b4dc493fb5b3bfce6e434832ca/md-2-big-Data.db]}} > > https://issues.apache.org/jira/browse/CASSANDRA-16619 -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org