[
https://issues.apache.org/jira/browse/CASSANDRA-18626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738057#comment-17738057
]
Andres de la Peña commented on CASSANDRA-18626:
-----------------------------------------------
The proposed patch follows the approach that was discussed for CASSANDRA-18617.
The deprecated properties are removed from {{cassandra.yaml}} and transformed
into the equivalent guardrails with a {{@Replaces}} tag. If an old
{{cassandra.yaml}} contains the old properties they will be used to set the
guardrails. But if they are absent, they will be disabled by default, same as
the guardrail.
||PR||CI||
|[trunk|https://github.com/apache/cassandra/pull/2454/files]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2989/workflows/c6882a4a-e85b-458a-9a22-235e9b892b8a]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2989/workflows/f1828d81-b01f-4258-a88e-2a45c749e2e7]|
|[dtest|https://github.com/apache/cassandra-dtest/pull/223]||
> compaction_tombstone_warning_threshold and
> compaction_large_partition_warning_threshold cause deprecation warnings
> ------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-18626
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18626
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Guardrails
> Reporter: Brandon Williams
> Assignee: Andres de la Peña
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> If you start trunk without any changes you will see at startup:
> {noformat}
> WARN [main] 2023-06-26 15:59:36,613 YamlConfigurationLoader.java:426 -
> [compaction_tombstone_warning_threshold,
> compaction_large_partition_warning_threshold] parameters have been
> deprecated. They have new names and/or value format; For more information,
> please refer to NEWS.txt
> {noformat}
> We should give these the same treatment as CASSANDRA-18617, removing them
> from the default yaml to stop the warnings, but still accepting them with
> converters and @Replaces tags.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
