[ 
https://issues.apache.org/jira/browse/CASSANDRA-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738630#comment-17738630
 ] 

Ekaterina Dimitrova commented on CASSANDRA-18467:
-------------------------------------------------

My +1 still stands on rebase and green CI. I did not see any other change than 
removing 
[https://github.com/apache/cassandra/pull/2320/files#diff-766797f233c18114f9499750cf1ffbf3829aeea50283850619c01bd173132021R1822-R1827]
 

Good point that one can be polished as wording and included for all JDKs.

I also support what was said here in favor of not adding new separate cleaning 
tasks. - [https://github.com/apache/cassandra/pull/2320/files#r1246637341]

(just adding it here so it is clear that was not forgotten/ignored but there 
was a reasonable discussion)

> Update generate-idea-files for J17
> ----------------------------------
>
>                 Key: CASSANDRA-18467
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18467
>             Project: Cassandra
>          Issue Type: Task
>          Components: Build
>            Reporter: Ekaterina Dimitrova
>            Assignee: Jakub Zytka
>            Priority: Low
>             Fix For: 5.x
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> There was a discussion in CASSANDRA-18258 how to update generate-idea-files.
> The final agreement was to create one target to cover both Java 11 and Java 
> 17.
> It will be good to figure out CASSANDRA-18263 and reshuffle arguments and 
> tasks based on what we decide to use as gc in testing for both Java 11 and 
> Java 17.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to