[ https://issues.apache.org/jira/browse/CASSANDRA-18645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739239#comment-17739239 ]
Ekaterina Dimitrova edited comment on CASSANDRA-18645 at 7/5/23 4:47 PM: ------------------------------------------------------------------------- We must remove the exclusion of failureaccess - Guava InternalFutureFailureAccess and InternalFuturesContains. >From maven: "com.google.common.util.concurrent.internal.InternalFutureFailureAccess and InternalFutures. Most Guava users will never need to use this artifact. Its classes are conceptually a part of Guava, but they were moved to a separate artifact so that Android libraries can use them without pulling in all of Guava (just as they can use ListenableFuture by depending on the listenablefuture artifact)." I did a quick preliminary run in CI a few weeks ago when I realized Guava added JDK17 - [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=test-guava]. I do not see any failures, but I am not surprised because, in newer Guava versions, there is a promise for no breakages in API, even if a method is deprecated. I have to finish next week the review of the Guava [release notes|https://github.com/google/guava/releases] before pushing this for review. was (Author: e.dimitrova): We must remove the exclusion of failureaccess - Guava InternalFutureFailureAccess and InternalFuturesContains. >From maven: "com.google.common.util.concurrent.internal.InternalFutureFailureAccess and InternalFutures. Most Guava users will never need to use this artifact. Its classes are conceptually a part of Guava, but they were moved to a separate artifact so that Android libraries can use them without pulling in all of Guava (just as they can use ListenableFuture by depending on the listenablefuture artifact)." I did a quick preliminary run in CI a few weeks ago when I realized Guava added JDK17 - [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=test-guava]. I do not see any failures, but I am not surprised because, in newer Guava versions, there is a promise for no breakages in API, even if a method is deprecated. I have to finish next week the review of the Guava [release notes|https://github.com/google/guava/releases?page=2] before pushing this for review. > Upgrade guava on trunk > ---------------------- > > Key: CASSANDRA-18645 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18645 > Project: Cassandra > Issue Type: Task > Components: Build > Reporter: Ekaterina Dimitrova > Assignee: Ekaterina Dimitrova > Priority: Normal > Labels: Dependency > Fix For: 5.x > > > Recently guava added JDK17 in CI and fixed some bugs down the road. > Upgrading before the major 5.0 release is something we should do. > Also, the current version that Cassandra uses is from 2018. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org