[ 
https://issues.apache.org/jira/browse/CASSANDRA-18639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741017#comment-17741017
 ] 

Stefan Miklosovic commented on CASSANDRA-18639:
-----------------------------------------------

I would keep it there because that one is just _estimation_. Right?

{code}
    /**
     * @return the number of unique elements in the stream or an estimate 
thereof
     */
    long cardinality();
{code}

But the figures under "-s" give you always exact numbers. So in theory they 
might differ.

BTW this which was already in trunk before this change seems to be just 
redundant because it will be printed also when '-s' is used.

{code}
field("totalColumnsSet", stats.totalColumnsSet);
field("totalRows", stats.totalRows);
{code}

It that same what we get after "-s"? If so, should not we remove this too? Or 
we keep it?


> Add duration and partition key count to sstablemetadata
> -------------------------------------------------------
>
>                 Key: CASSANDRA-18639
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18639
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tool/sstable
>            Reporter: Timothy Tu
>            Assignee: Timothy Tu
>            Priority: Normal
>             Fix For: 5.x
>
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> The new additions will output metadata information for:
>  * Partition Key Count
>  * Duration
> Partition key count is the total number of partitions in the sstable..
> For Time Window Compaction (TWC), the min and max timestamps together with 
> duration describe the bounds of the time window in the table.
> {quote}{{Total partitions: 2430}}
> {{Total rows: 8000}}
> {{Total column set: 100000}}
> {{...}}
> {{Min Timestamp: 06/28/2023 15:15:04 (1688067443651650)}}
> {{Max Timestamp: 06/28/2023 15:15:58 (1688067500268865)}}
> {{Duration Days: 0 Hours: 0 Minutes: 0 Seconds: 53}}
> {quote}
> The online docs in sstablemetadata.adoc will need to be updated as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to