[ https://issues.apache.org/jira/browse/CASSANDRA-18438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17741875#comment-17741875 ]
Maxwell Guo edited comment on CASSANDRA-18438 at 7/11/23 7:15 AM: ------------------------------------------------------------------ Thanks for [~smiklosovic]'s work, and I have just tested the alibabclousnitch under alibabacloud' ecs , and the result are all right. !alicloud-snitch.png! Steps : 1. set the snitch with AlibabacloudSnitch in the cassandra.yaml 2. start cassandra 3.using nodetool status to see the dc and rack name; the result is : dc : cn-hangzhou and rack : h 4.curl the alibaba ecs meta center and the result is : cn-hangzhou-h the result are matched. was (Author: maxwellguo): Thanks for [~smiklosovic]'s work, and I have just test the snitch under alibabacloud' ecs , and the result are all right. !alicloud-snitch.png! test step : 1. I set the snitch with AlibabacloudSnitch in the cassandra.yaml 2. start cassandra 3.using nodetool status to see the dc and rack name; the result is : dc : cn-hangzhou and rack : h 4.I curl the alibaba ecs meta center and the result is : cn-hangzhou-h the result are matched. > Refactor cloud snitches to get rid of duplicate code > ---------------------------------------------------- > > Key: CASSANDRA-18438 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18438 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other > Reporter: Maxwell Guo > Assignee: Maxwell Guo > Priority: Normal > Fix For: 5.x > > Attachments: alicloud-snitch.png > > Time Spent: 3.5h > Remaining Estimate: 0h > > Nowadays we have got about four public cloud platform snitchs : EC2 snitch > for aws, google cloud snitch for google cloud, alibaba cloud snitch for > alibaba cloud and multi region snitch for ec2. And the common place for the > first three is that we just need to query the zone center to get the ec2 / > ecs id , so I think we can refactor the code , and if some new public cloud > platform want to add one more snitch for himself, there is no need to pull a > pr for him and configure some options in yaml is enough . > Besides it would be even better that we may reuse the multic region snitch > for ec2 for other public cloud platform. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org