[ https://issues.apache.org/jira/browse/CASSANDRA-18438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742941#comment-17742941 ]
Stefan Miklosovic edited comment on CASSANDRA-18438 at 7/14/23 7:55 AM: ------------------------------------------------------------------------ j11 https://app.circleci.com/pipelines/github/instaclustr/cassandra/2697/workflows/c7a98a17-6df8-43df-a10a-4d7efad21dba j8 https://app.circleci.com/pipelines/github/instaclustr/cassandra/2702/workflows/ec4101ef-72d5-4e1a-abd0-4e8a91db6df0 Jacek and Maxwell +1ed on the PR already. j11 is clean, j8 contains few known flakes. This patch also deprecates CloudstackSnitch which was discussed here https://lists.apache.org/thread/2zxvbjoynhvsr33cc9h9xv99sdvjldn8 was (Author: smiklosovic): j11 https://app.circleci.com/pipelines/github/instaclustr/cassandra/2697/workflows/c7a98a17-6df8-43df-a10a-4d7efad21dba j8 https://app.circleci.com/pipelines/github/instaclustr/cassandra/2697/workflows/2d15d219-f806-4abf-a349-0c36f69a5c9c Jacek and Maxwell +1ed on the PR already. j11 is clean, j8 contains few known flakes. This patch also deprecates CloudstackSnitch which was discussed here https://lists.apache.org/thread/2zxvbjoynhvsr33cc9h9xv99sdvjldn8 > Refactor cloud snitches to get rid of duplicate code > ---------------------------------------------------- > > Key: CASSANDRA-18438 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18438 > Project: Cassandra > Issue Type: Improvement > Components: Local/Other > Reporter: Maxwell Guo > Assignee: Stefan Miklosovic > Priority: Normal > Fix For: 5.x > > Attachments: alicloud-snitch.png, image-2023-07-12-17-28-24-723.png, > image-2023-07-12-17-30-53-158.png, image-2023-07-12-17-31-37-447.png > > Time Spent: 5h 50m > Remaining Estimate: 0h > > Nowadays we have got about four public cloud platform snitchs : EC2 snitch > for aws, google cloud snitch for google cloud, alibaba cloud snitch for > alibaba cloud and multi region snitch for ec2. And the common place for the > first three is that we just need to query the zone center to get the ec2 / > ecs id , so I think we can refactor the code , and if some new public cloud > platform want to add one more snitch for himself, there is no need to pull a > pr for him and configure some options in yaml is enough . > Besides it would be even better that we may reuse the multic region snitch > for ec2 for other public cloud platform. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org