[ 
https://issues.apache.org/jira/browse/CASSANDRA-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751023#comment-17751023
 ] 

Stefan Miklosovic commented on CASSANDRA-17992:
-----------------------------------------------

[~jlewandowski] [~e.dimitrova]

I see that we are depending on netty-transport-native-epoll with linux_x86_64 
classifier and we put this dependency directly into parent's pom etc.

However, there is also classifier with aarch64, check this (first few links).

https://repo1.maven.org/maven2/io/netty/netty-transport-native-epoll/4.1.96.Final/

This means that when we run this on ARM, since you put x86_64 dependency on the 
class path, it will not work (presumably) 

How it needs to be done is that you need to put both dependencies into profiles 
(1) and into lib/"platform" (2) when these dependencies are resolved  and then 
you need to dynamically add it on the class path based on what platform the 
code runs on (this is automatically done in 
https://github.com/apache/cassandra/blob/trunk/bin/cassandra.in.sh#L87-L92)

Basically same way how it was done in Corretto crypto provider.

In a nutshell, we are not multiplatform here, we wired it to x86_64 but there 
is no reason to not support aarch64 too.

(1) 
https://github.com/apache/cassandra/blob/trunk/.build/parent-pom-template.xml#L247-L283
(2) 
https://github.com/apache/cassandra/blob/trunk/.build/build-resolver.xml#L213-L228

> Upgrade Netty on 5.0
> --------------------
>
>                 Key: CASSANDRA-17992
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17992
>             Project: Cassandra
>          Issue Type: Task
>          Components: Dependencies
>            Reporter: Ekaterina Dimitrova
>            Assignee: Jacek Lewandowski
>            Priority: Normal
>             Fix For: 5.0
>
>         Attachments: important-netty-inter-releases.md, 
> netty-release-notes-filtered.md, netty-release-notes.md
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> I haven't been able to identify from the Netty docs which was the lowest 
> version where JDK17 was added but we are about 40 versions behind in netty 4 
> so I suspect we better update. 
> -We need to consider there was an issue with class cast exceptions when 
> building with JDK17 with newer versions of netty (the newest available in 
> March 2022). For the record, we didn't see those when running CI on JDK8 and 
> JDK11. We also need to carefully revise the changes between the netty 
> versions. -->- CASSANDRA-18180
> Upgrading will cover also a fix in netty that was discussed in 
> [this|https://the-asf.slack.com/archives/CK23JSY2K/p1665567660202989] ASF 
> Slack thread. 
> CC [~benedict] , [~aleksey] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to