[
https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17764362#comment-17764362
]
Maxim Muzafarov commented on CASSANDRA-14667:
---------------------------------------------
{quote}I am not following. I did not see dropwizard pulling a new version of
slf4j? Which pom are you looking at?{quote}
As I understand it, the dependency only needs to be downloaded once and then it
lives in the .m2/repository cache directory, so it doesn't need to be
downloaded from scratch every time. So, the most important thing for us to look
at is the presence of a library in the build/jar directory. This directory
defines the application classpath we use (correct me if I'm wrong).
If we take a step back and have a closer look at the build/jar directory, there
is only one logback-core library of version 1.2.9 and there is no 1.2.12 (which
was transitevly inherited from the dropwizard library). I don't know why the
original concerns were raised, but as I can see from the block of code you
posted it only downloads the pom files required to resolve the dropwizard
dependency description itself. There is still no 1.2.12 jar in the resulting
classpath, which seems correct to me.
I'm not arguing against the 1.2.9 -> 1.2.12 upgrade as that seems to be more
natural to me as well, but by the same logic we used applied with adding an
exclusion for the logback library to the dropwizard dependency I have also
raised some concerns about adding an exclusion (and upgrade as well) of the
slf4j-api dependency to the dropwizard. For example, the same exclusion was
previously added for the ohc here:
https://github.com/apache/cassandra/blob/trunk/.build/parent-pom-template.xml#L965
No matter how we are currently manage dependencies, there are no duplicates in
the resulting classpath.
> Upgrade Dropwizard Metrics to 4.x
> ---------------------------------
>
> Key: CASSANDRA-14667
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14667
> Project: Cassandra
> Issue Type: Task
> Components: Observability/Metrics
> Reporter: Stig Rohde Døssing
> Assignee: Maxim Muzafarov
> Priority: Normal
> Fix For: 5.x
>
> Attachments: signature.asc, signature.asc
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for
> Java 9 compatibility. It would be good to upgrade the Metrics library as part
> of the version of Cassandra that adds Java 9 compatibility
> (https://issues.apache.org/jira/browse/CASSANDRA-9608).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
