[
https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768672#comment-17768672
]
Maxim Muzafarov commented on CASSANDRA-14667:
---------------------------------------------
[~e.dimitrova] I didn't see a clear agreement to update the slf4j-api library,
so I didn't include it in the patch.
For me, the there are a few reasons for not doing this in this patch:
- The slf4j-api dependency is important in its own right and deserves its own
patch, in case we have to revert the following patch due to some undiscovered
problem and/or slf4j still needs to be preserved;
- The slf4j-api module is a module that provides a public API, and according to
the slf4j release policy only changes between the major releases, even if you
still see the patch versions it is released as a maven module without any
changes and nothing more. For example, the latest change related to this module
itself is change c6c7a98a7ee1e71382348ae3e41ff7818dfafd65 dated Dec 16, 2019
despite the latest 1.7.36 version is released on Feb 8, 2022.
- We've already removed this library from the transitive dependencies for the
dropwizrd library.
In summary, including the slf4j-api version update is not required for this
patch. The API that is provided by slf4j and that is used by Cassandra is the
same and it only overcomplicates the overall solution by causing unnecessary
questions for those developers who will be faced with this patch later.
So I suggest proceeding with this patch without the slf4j-api alongside the
update and if we still want to - create another issue for it, but for the same
reasons that were mentioned above there is no need for the 1.7.24 > 1.7.36
upgrade as it gives us nothing.
> Upgrade Dropwizard Metrics to 4.x
> ---------------------------------
>
> Key: CASSANDRA-14667
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14667
> Project: Cassandra
> Issue Type: Task
> Components: Observability/Metrics
> Reporter: Stig Rohde Døssing
> Assignee: Maxim Muzafarov
> Priority: Normal
> Fix For: 5.0.x, 5.x
>
> Attachments: signature.asc, signature.asc, signature.asc,
> signature.asc
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for
> Java 9 compatibility. It would be good to upgrade the Metrics library as part
> of the version of Cassandra that adds Java 9 compatibility
> (https://issues.apache.org/jira/browse/CASSANDRA-9608).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
