[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776558#comment-17776558 ]
Stefan Miklosovic commented on CASSANDRA-18935: ----------------------------------------------- I think there is also another issue if you start it all just fine and then you do nodetool disablebinary it will not set rpc to false. so then this https://github.com/apache/cassandra/commit/36bdc253193318ceaf5beb9bc5e869f6af590cb1 it will still think rpc is true / that native transport is running there > Unable to write to counter table if native transport is disabled on startup > --------------------------------------------------------------------------- > > Key: CASSANDRA-18935 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18935 > Project: Cassandra > Issue Type: Bug > Reporter: Cameron Zemek > Priority: Normal > Attachments: 18935-3.11.patch > > > > {code:java} > if ((nativeFlag != null && Boolean.parseBoolean(nativeFlag)) || > (nativeFlag == null && DatabaseDescriptor.startNativeTransport())) > { > startNativeTransport(); > StorageService.instance.setRpcReady(true); > } {code} > The startup code here only sets RpcReady if native transport is enabled. If > you call > {code:java} > nodetool enablebinary{code} > then this flag doesn't get set. > But with the change from CASSANDRA-13043 it requires RpcReady set to true in > order to get a leader for the counter update. > Not sure what the correct fix is here, seems to only really use this flag for > counters. So thinking perhaps the fix is to just move this outside the if > condition. > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org