[
https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787497#comment-17787497
]
Stefan Miklosovic commented on CASSANDRA-18935:
-----------------------------------------------
I think we should just remove that one line and that's it, for the sake of not
having this regression in 5.0.0. We will wait until CEP-21 (TCM) is in place,
should be pretty soon. If you check TCM logic in that method, it was rewritten
(1) so it does not make sense to introduce new gossip message etc, this stuff
is apparently going to be handled differently quite soon.
After TCM changes are in, I think we can finally decouple this rpc readiness
from counter's logic and then we can fix enable/disable binary behaviour when
it comes to RPC status.
(1)
https://github.com/apache/cassandra/blob/cep-21-tcm/src/java/org/apache/cassandra/locator/ReplicaPlans.java#L212-L221
> Fix nodetool enable/disablebinary to correctly set rpc
> ------------------------------------------------------
>
> Key: CASSANDRA-18935
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18935
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Core, Legacy/CQL
> Reporter: Cameron Zemek
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0-rc, 5.x
>
> Attachments: 18935-3.11.patch, image-2023-11-16-10-56-16-693.png,
> signature.asc
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
>
> {code:java}
> if ((nativeFlag != null && Boolean.parseBoolean(nativeFlag)) ||
> (nativeFlag == null && DatabaseDescriptor.startNativeTransport()))
> {
> startNativeTransport();
> StorageService.instance.setRpcReady(true);
> } {code}
> The startup code here only sets RpcReady if native transport is enabled. If
> you call
> {code:java}
> nodetool enablebinary{code}
> then this flag doesn't get set.
> But with the change from CASSANDRA-13043 it requires RpcReady set to true in
> order to get a leader for the counter update.
> Not sure what the correct fix is here, seems to only really use this flag for
> counters. So thinking perhaps the fix is to just move this outside the if
> condition.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
