[ https://issues.apache.org/jira/browse/CASSANDRA-18935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791001#comment-17791001 ]
Stefan Miklosovic commented on CASSANDRA-18935: ----------------------------------------------- I built the patch for trunk as TCM has happened there (1). Even the build contains a lot of failures, this is all known and tracked and I do not see anything wrong with the patch itself. Also, for the reference, test_counter_leader_with_partial_view test is NOT flaky. I run the multiplexer and it all just passes fine. So I had to introduce the instability in my attempt to bring in the changes in located in CASSANDRA-19103. Anyway, as already communicated, we go without that. I am starting the merging process. (1) [https://app.circleci.com/pipelines/github/instaclustr/cassandra/3572/workflows/70ea8bc0-08c3-472c-a292-a1c050bc65dd] > Fix nodetool enable/disablebinary to correctly set rpc > ------------------------------------------------------ > > Key: CASSANDRA-18935 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18935 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Core, Legacy/CQL > Reporter: Cameron Zemek > Assignee: Stefan Miklosovic > Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.0.x, 5.x > > Attachments: 18935-3.11.patch, image-2023-11-16-10-56-16-693.png, > signature.asc > > Time Spent: 2.5h > Remaining Estimate: 0h > > > {code:java} > if ((nativeFlag != null && Boolean.parseBoolean(nativeFlag)) || > (nativeFlag == null && DatabaseDescriptor.startNativeTransport())) > { > startNativeTransport(); > StorageService.instance.setRpcReady(true); > } {code} > The startup code here only sets RpcReady if native transport is enabled. If > you call > {code:java} > nodetool enablebinary{code} > then this flag doesn't get set. > But with the change from CASSANDRA-13043 it requires RpcReady set to true in > order to get a leader for the counter update. > Not sure what the correct fix is here, seems to only really use this flag for > counters. So thinking perhaps the fix is to just move this outside the if > condition. > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org