[
https://issues.apache.org/jira/browse/CASSANDRA-19276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808440#comment-17808440
]
Andy Tolbert commented on CASSANDRA-19276:
------------------------------------------
Did a quick analysis on how many violations currently exist, apparently I had
missed tests in my first analysis. Here is a break down of checkstyle errors by
token and whether I think they should be included (tokens defined
[here|https://checkstyle.sourceforge.io/checks/blocks/leftcurly.html]):
||Type||Src Errors||Errors||Include?||
|ANNOTATION_DEF|0|0|Yes|
|CLASS_DEF|8|28|Yes|
|CTOR_DEF|55|24|Yes|
|ENUM_CONSTANT_DEF|2|6|Yes|
|INTERFACE_DEF|4|15|Yes|
|LAMBDA|372|1719|No|
|LITERAL_CASE|0|2|Yes|
|LITERAL_CATCH|17|70|Yes|
|LITERAL_DEFAULT|0|0|Yes|
|LITERAL_DO|7|1|Yes|
|LITERAL_ELSE|13|11|Yes|
|LITERAL_FINALLY|1|13|Yes|
|LITERAL_FOR|13|41|Yes|
|LITERAL_IF|68|52|Yes|
|LITERAL_SWITCH|1|2|Yes|
|LITERAL_SYNCHRONIZED|2|0|Yes|
|LITERAL_TRY|19|63|Yes|
|LITERAL_WHILE|15|10|Yes|
|METHOD_DEF|302|408|Yes|
|OBJBLOCK|79|198|Yes|
|STATIC_INIT|3|3|Yes|
|RECORD_DEF|0|0|Yes|
|COMPACT_CTOR_DEF|0|0|Yes|
|*Total (excl LAMBDA)*|595|898|n/a|
(small note: that if you add the numbers up, they eclipse the "Total" because
there is some overlap in the rules, the "Total (excl LAMBDA)" value was
calculated by running with all tokens except lamdba included.)
A large amount of the violations are on METHOD_DEF (declaration of a method),
usually where a method is a single collapsed line, .e.g:
{code:java}
public int getActiveTaskCount() { return 0; }
public long getCompletedTaskCount() { return 0; }
public int getPendingTaskCount() { return 0; }
public int getCorePoolSize() { return 0; }
public int getMaximumPoolSize() { return 0; }{code}
We could consider leaving these as is, but it would also be low effort to
change them. Unfortunately I can't seem to find a way to allow this particular
use while also forbidding multi-line methods that have left braces in the
declaration line, but i'll keep looking.
A good deal of violations come from a small set of files. I would suggest for
files that were inline from elsewhere that we suppress checkstyle on them.
||count||file||Copied from elsewhere?||
|70|src/java/org/apache/cassandra/utils/LongTimSort.java|Yes|
|25|src/java/org/apache/cassandra/locator/ReplicaPlan.java|No|
|21|src/java/org/apache/cassandra/service/StorageProxy.java|No|
|16|src/java/org/apache/cassandra/utils/ByteArrayUtil.java|Partially|
|16|src/java/org/apache/cassandra/net/OutboundConnection.java|No|
|14|src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java|No|
|13|src/java/org/apache/cassandra/service/paxos/ContentionStrategy.java|No|
|12|src/java/org/apache/cassandra/concurrent/ImmediateExecutor.java|No|
|10|src/java/org/apache/cassandra/service/paxos/PaxosPrepare.java|No|
|9|src/java/org/apache/cassandra/utils/JMXServerUtils.java|Partially|
|9|src/java/org/apache/cassandra/concurrent/NamedThreadFactory.java|No|
|8|src/java/org/apache/cassandra/utils/obs/BitUtil.java|Yes|
|8|src/java/org/apache/cassandra/utils/btree/AbstractBTreeMap.java|No|
|8|src/java/org/apache/cassandra/utils/MBeanWrapper.java|No|
|8|src/java/org/apache/cassandra/service/paxos/PaxosPropose.java|No|
|8|src/java/org/apache/cassandra/net/OutboundConnectionInitiator.java|No|
|8|src/java/com/datastax/driver/core/PreparedStatementHelper.java|No|
|7|src/java/org/apache/cassandra/utils/btree/BTreeMultimap.java|No|
|7|src/java/org/apache/cassandra/utils/ExpiringMemoizingSupplier.java|No|
|6|src/java/org/apache/cassandra/utils/WithResources.java|No|
|6|src/java/org/apache/cassandra/tools/StandaloneSplitter.java|No|
|6|src/java/org/apache/cassandra/io/util/SequentialWriter.java|No|
|6|src/java/org/apache/cassandra/concurrent/Stage.java|No|
|5|src/java/org/apache/cassandra/utils/FilterFactory.java|No|
|5|src/java/org/apache/cassandra/service/paxos/uncommitted/UncommittedDataFile.java|No|
|5|src/java/org/apache/cassandra/service/paxos/BallotGenerator.java|No|
|5|src/java/org/apache/cassandra/index/sai/disk/v1/vector/VectorPostingsWriter.java|No|
|5|src/java/org/apache/cassandra/db/transform/Transformation.java|No|
|5|src/java/org/apache/cassandra/concurrent/ExecutorFactory.java|No|
|4|src/java/org/apache/cassandra/utils/MonotonicClock.java|No|
|4|src/java/org/apache/cassandra/transport/Event.java|No|
|4|src/java/org/apache/cassandra/metrics/ClientMetrics.java|No|
|4|src/java/org/apache/cassandra/locator/RangesAtEndpoint.java|No|
|4|src/java/org/apache/cassandra/index/sasi/utils/RangeIterator.java|No|
|4|src/java/org/apache/cassandra/index/sai/iterators/KeyRangeIterator.java|No|
|4|src/java/org/apache/cassandra/concurrent/InfiniteLoopExecutor.java|No|
|3|src/java/org/apache/cassandra/utils/memory/BufferPool.java|No|
|3|src/java/org/apache/cassandra/tools/nodetool/ViewBuildStatus.java|No|
|3|src/java/org/apache/cassandra/streaming/StreamSession.java|No|
|3|src/java/org/apache/cassandra/service/paxos/PaxosState.java|No|
|3|src/java/org/apache/cassandra/service/paxos/PaxosCommit.java|No|
|3|src/java/org/apache/cassandra/service/StorageService.java|No|
|3|src/java/org/apache/cassandra/locator/EndpointsForToken.java|No|
|3|src/java/org/apache/cassandra/locator/EndpointsForRange.java|No|
|3|src/java/org/apache/cassandra/index/sai/metrics/ColumnQueryMetrics.java|No|
|3|src/java/org/apache/cassandra/cql3/statements/BatchStatement.java|No|
|3|src/java/org/apache/cassandra/concurrent/ExecutorBuilderFactory.java|No|
|2|src/java/org/apache/cassandra/utils/concurrent/Transactional.java|No|
|2|src/java/org/apache/cassandra/utils/concurrent/ConditionAsConsumer.java|No|
|2|src/java/org/apache/cassandra/utils/VoidSerializer.java|No|
|2|src/java/org/apache/cassandra/utils/Shared.java|No|
|2|src/java/org/apache/cassandra/utils/ReflectionUtils.java|No|
|2|src/java/org/apache/cassandra/utils/JVMStabilityInspector.java|No|
|2|src/java/org/apache/cassandra/utils/HistogramBuilder.java|No|
|2|src/java/org/apache/cassandra/utils/GuidGenerator.java|No|
|2|src/java/org/apache/cassandra/transport/messages/PrepareMessage.java|No|
|2|src/java/org/apache/cassandra/tools/nodetool/stats/TableStatsHolder.java|No|
|2|src/java/org/apache/cassandra/tools/NodeTool.java|No|
|2|src/java/org/apache/cassandra/tools/GetVersion.java|No|
|2|src/java/org/apache/cassandra/tcm/AtomicLongBackedProcessor.java|No|
|2|src/java/org/apache/cassandra/service/paxos/Paxos.java|No|
|2|src/java/org/apache/cassandra/service/paxos/AbstractPaxosRepair.java|No|
|2|src/java/org/apache/cassandra/security/SSLFactory.java|No|
|2|src/java/org/apache/cassandra/net/ResourceLimits.java|No|
|2|src/java/org/apache/cassandra/net/NoSizeEstimator.java|No|
|2|src/java/org/apache/cassandra/net/InboundSockets.java|No|
|2|src/java/org/apache/cassandra/metrics/DecayingEstimatedHistogramReservoir.java|No|
|2|src/java/org/apache/cassandra/io/util/PathUtils.java|No|
|2|src/java/org/apache/cassandra/io/util/File.java|No|
|2|src/java/org/apache/cassandra/io/compress/CompressedSequentialWriter.java|No|
|2|src/java/org/apache/cassandra/index/sasi/analyzer/DelimiterAnalyzer.java|No|
|2|src/java/org/apache/cassandra/index/sai/disk/io/IndexOutputWriter.java|No|
|2|src/java/org/apache/cassandra/index/sai/disk/ResettableByteBuffersIndexOutput.java|No|
|2|src/java/org/apache/cassandra/index/sai/analyzer/filter/BasicFilters.java|No|
|2|src/java/org/apache/cassandra/hints/HintsDispatcher.java|No|
|2|src/java/org/apache/cassandra/dht/RandomPartitioner.java|No|
|2|src/java/org/apache/cassandra/db/rows/BTreeRow.java|No|
|2|src/java/org/apache/cassandra/db/marshal/UserType.java|No|
|2|src/java/org/apache/cassandra/db/marshal/EmptyType.java|No|
|2|src/java/org/apache/cassandra/db/compaction/unified/Controller.java|No|
|2|src/java/org/apache/cassandra/db/compaction/CompactionManager.java|No|
|2|src/java/org/apache/cassandra/db/Directories.java|No|
|2|src/java/org/apache/cassandra/db/ColumnFamilyStore.java|No|
|2|src/java/org/apache/cassandra/cql3/statements/schema/AlterTableStatement.java|No|
|2|src/java/org/apache/cassandra/config/EncryptionOptions.java|No|
|2|src/java/org/apache/cassandra/concurrent/TaskFactory.java|No|
|2|src/java/org/apache/cassandra/cache/SerializingCache.java|No|
|1|src/java/org/apache/cassandra/utils/progress/jmx/JMXBroadcastExecutor.java|No|
|1|src/java/org/apache/cassandra/utils/concurrent/NonBlockingRateLimiter.java|No|
|1|src/java/org/apache/cassandra/utils/concurrent/Condition.java|No|
|1|src/java/org/apache/cassandra/utils/bytecomparable/ByteSourceInverse.java|No|
|1|src/java/org/apache/cassandra/utils/Throwables.java|No|
|1|src/java/org/apache/cassandra/utils/NullableSerializer.java|No|
|1|src/java/org/apache/cassandra/utils/Nemesis.java|No|
|1|src/java/org/apache/cassandra/utils/MerkleTree.java|No|
|1|src/java/org/apache/cassandra/utils/AbstractIterator.java|No|
|1|src/java/org/apache/cassandra/transport/SimpleClient.java|No|
|1|src/java/org/apache/cassandra/transport/Flusher.java|No|
|1|src/java/org/apache/cassandra/transport/Envelope.java|No|
|1|src/java/org/apache/cassandra/transport/ClientResourceLimits.java|No|
|1|src/java/org/apache/cassandra/transport/CQLMessageHandler.java|No|
|1|src/java/org/apache/cassandra/tools/nodetool/stats/CompactionHistoryPrinter.java|No|
|1|src/java/org/apache/cassandra/tools/nodetool/formatter/TableBuilder.java|No|
|1|src/java/org/apache/cassandra/tools/nodetool/Status.java|No|
|1|src/java/org/apache/cassandra/tools/nodetool/Snapshot.java|No|
|1|src/java/org/apache/cassandra/tools/nodetool/Sjk.java|No|
|1|src/java/org/apache/cassandra/tools/nodetool/InvalidatePermissionsCache.java|No|
|1|src/java/org/apache/cassandra/tools/nodetool/Compact.java|No|
|1|src/java/org/apache/cassandra/tools/StandaloneVerifier.java|No|
|1|src/java/org/apache/cassandra/tools/NodeProbe.java|No|
|1|src/java/org/apache/cassandra/tools/JsonTransformer.java|No|
|1|src/java/org/apache/cassandra/tcm/log/LocalLog.java|No|
|1|src/java/org/apache/cassandra/streaming/StreamingChannel.java|No|
|1|src/java/org/apache/cassandra/streaming/StreamTransferTask.java|No|
|1|src/java/org/apache/cassandra/streaming/StreamState.java|No|
|1|src/java/org/apache/cassandra/service/snapshot/TableSnapshot.java|No|
|1|src/java/org/apache/cassandra/service/snapshot/SnapshotManager.java|No|
|1|src/java/org/apache/cassandra/service/reads/ReplicaFilteringProtection.java|No|
|1|src/java/org/apache/cassandra/service/reads/ReadCallback.java|No|
|1|src/java/org/apache/cassandra/service/paxos/Commit.java|No|
|1|src/java/org/apache/cassandra/service/StartupChecks.java|No|
|1|src/java/org/apache/cassandra/service/DataResurrectionCheck.java|No|
|1|src/java/org/apache/cassandra/service/CassandraDaemon.java|No|
|1|src/java/org/apache/cassandra/serializers/SimpleDateSerializer.java|No|
|1|src/java/org/apache/cassandra/security/ThreadAwareSecurityManager.java|No|
|1|src/java/org/apache/cassandra/schema/TableMetadataRef.java|No|
|1|src/java/org/apache/cassandra/schema/Schema.java|No|
|1|src/java/org/apache/cassandra/schema/ReplicationParams.java|No|
|1|src/java/org/apache/cassandra/repair/state/ParticipateState.java|No|
|1|src/java/org/apache/cassandra/repair/state/AbstractCompletable.java|No|
|1|src/java/org/apache/cassandra/repair/messages/RepairMessage.java|No|
|1|src/java/org/apache/cassandra/repair/consistent/LocalSessions.java|No|
|1|src/java/org/apache/cassandra/repair/consistent/ConsistentSession.java|No|
|1|src/java/org/apache/cassandra/repair/SharedContext.java|No|
|1|src/java/org/apache/cassandra/repair/RepairMessageVerbHandler.java|No|
|1|src/java/org/apache/cassandra/net/OutboundMessageQueue.java|No|
|1|src/java/org/apache/cassandra/net/FrameDecoder.java|No|
|1|src/java/org/apache/cassandra/net/AbstractMessageHandler.java|No|
|1|src/java/org/apache/cassandra/metrics/RestorableMeter.java|No|
|1|src/java/org/apache/cassandra/locator/ReplicaPlans.java|No|
|1|src/java/org/apache/cassandra/locator/ReplicaLayout.java|No|
|1|src/java/org/apache/cassandra/locator/NetworkTopologyStrategy.java|No|
|1|src/java/org/apache/cassandra/locator/InetAddressAndPort.java|No|
|1|src/java/org/apache/cassandra/locator/Endpoints.java|No|
|1|src/java/org/apache/cassandra/io/util/FileUtils.java|No|
|1|src/java/org/apache/cassandra/io/util/DataOutputBuffer.java|No|
|1|src/java/org/apache/cassandra/io/sstable/indexsummary/IndexSummaryManager.java|No|
|1|src/java/org/apache/cassandra/io/sstable/format/bti/BtiFormat.java|No|
|1|src/java/org/apache/cassandra/io/sstable/format/SortedTableVerifier.java|No|
|1|src/java/org/apache/cassandra/io/sstable/CQLSSTableWriter.java|No|
|1|src/java/org/apache/cassandra/io/sstable/AbstractSSTableIterator.java|No|
|1|src/java/org/apache/cassandra/io/compress/ICompressor.java|No|
|1|src/java/org/apache/cassandra/index/sasi/utils/trie/PatriciaTrie.java|No|
|1|src/java/org/apache/cassandra/index/sasi/memory/SkipListMemIndex.java|No|
|1|src/java/org/apache/cassandra/index/sasi/exceptions/TimeQuotaExceededException.java|No|
|1|src/java/org/apache/cassandra/index/sasi/disk/AbstractTokenTreeBuilder.java|No|
|1|src/java/org/apache/cassandra/index/sai/metrics/TableStateMetrics.java|No|
|1|src/java/org/apache/cassandra/index/sai/disk/v1/vector/RamEstimation.java|No|
|1|src/java/org/apache/cassandra/index/sai/disk/v1/vector/DiskAnn.java|No|
|1|src/java/org/apache/cassandra/index/sai/disk/v1/vector/CompactionVectorValues.java|No|
|1|src/java/org/apache/cassandra/index/sai/disk/v1/LongArray.java|No|
|1|src/java/org/apache/cassandra/index/sai/disk/format/Version.java|No|
|1|src/java/org/apache/cassandra/index/sai/disk/RowMapping.java|No|
|1|src/java/org/apache/cassandra/index/internal/composites/CompositesSearcher.java|No|
|1|src/java/org/apache/cassandra/index/Index.java|No|
|1|src/java/org/apache/cassandra/gms/FailureDetector.java|No|
|1|src/java/org/apache/cassandra/exceptions/UnrecoverableIllegalStateException.java|No|
|1|src/java/org/apache/cassandra/diag/LastEventIdBroadcaster.java|No|
|1|src/java/org/apache/cassandra/dht/OrderPreservingPartitioner.java|No|
|1|src/java/org/apache/cassandra/db/transform/RTBoundValidator.java|No|
|1|src/java/org/apache/cassandra/db/rows/UnfilteredRowIterators.java|No|
|1|src/java/org/apache/cassandra/db/rows/Unfiltered.java|No|
|1|src/java/org/apache/cassandra/db/rows/ColumnData.java|No|
|1|src/java/org/apache/cassandra/db/partitions/UnfilteredPartitionIterators.java|No|
|1|src/java/org/apache/cassandra/db/marshal/UTF8Type.java|No|
|1|src/java/org/apache/cassandra/db/marshal/TimestampType.java|No|
|1|src/java/org/apache/cassandra/db/marshal/TimeType.java|No|
|1|src/java/org/apache/cassandra/db/marshal/SimpleDateType.java|No|
|1|src/java/org/apache/cassandra/db/marshal/LongType.java|No|
|1|src/java/org/apache/cassandra/db/marshal/IntegerType.java|No|
|1|src/java/org/apache/cassandra/db/marshal/InetAddressType.java|No|
|1|src/java/org/apache/cassandra/db/marshal/FloatType.java|No|
|1|src/java/org/apache/cassandra/db/marshal/DoubleType.java|No|
|1|src/java/org/apache/cassandra/db/marshal/DecimalType.java|No|
|1|src/java/org/apache/cassandra/db/marshal/DateType.java|No|
|1|src/java/org/apache/cassandra/db/marshal/CounterColumnType.java|No|
|1|src/java/org/apache/cassandra/db/marshal/BytesType.java|No|
|1|src/java/org/apache/cassandra/db/marshal/BooleanType.java|No|
|1|src/java/org/apache/cassandra/db/marshal/AsciiType.java|No|
|1|src/java/org/apache/cassandra/db/lifecycle/LogTransaction.java|No|
|1|src/java/org/apache/cassandra/db/lifecycle/LogRecord.java|No|
|1|src/java/org/apache/cassandra/db/filter/RowFilter.java|No|
|1|src/java/org/apache/cassandra/db/filter/ColumnSubselection.java|No|
|1|src/java/org/apache/cassandra/db/compaction/unified/ShardedMultiWriter.java|No|
|1|src/java/org/apache/cassandra/db/commitlog/DirectIOSegment.java|No|
|1|src/java/org/apache/cassandra/db/commitlog/CommitLogReplayer.java|No|
|1|src/java/org/apache/cassandra/db/SystemKeyspace.java|No|
|1|src/java/org/apache/cassandra/db/ReadCommand.java|No|
|1|src/java/org/apache/cassandra/db/NativeClustering.java|No|
|1|src/java/org/apache/cassandra/db/MutationExceededMaxSizeException.java|No|
|1|src/java/org/apache/cassandra/db/Keyspace.java|No|
|1|src/java/org/apache/cassandra/db/ExpirationDateOverflowHandling.java|No|
|1|src/java/org/apache/cassandra/cql3/UntypedResultSet.java|No|
|1|src/java/org/apache/cassandra/cql3/Term.java|No|
|1|src/java/org/apache/cassandra/cql3/QueryOptions.java|No|
|1|src/java/org/apache/cassandra/config/Config.java|No|
|1|src/java/org/apache/cassandra/config/CassandraRelevantEnv.java|No|
|1|src/java/org/apache/cassandra/concurrent/Interruptible.java|No|
|1|src/java/org/apache/cassandra/cache/CaffeineCache.java|No|
|1|src/java/org/apache/cassandra/auth/AbstractCIDRAuthorizer.java|No|
tests:
||count||file||Copied from elsewhere?||
|47|test/unit/org/apache/cassandra/CassandraXMLJUnitResultFormatter.java|No|
|38|test/unit/org/apache/cassandra/CassandraBriefJUnitResultFormatter.java|No|
|32|test/unit/accord/utils/Gens.java|No|
|26|test/microbench/org/apache/cassandra/test/microbench/OutputStreamBench.java|No|
|22|test/distributed/org/apache/cassandra/distributed/impl/IsolatedExecutor.java|No|
|21|test/unit/org/apache/cassandra/utils/MergeIteratorComparisonTest.java|No|
|18|test/unit/org/apache/cassandra/io/util/NIODataInputStreamTest.java|No|
|15|test/unit/org/apache/cassandra/db/filter/RowFilterTest.java|No|
|15|test/unit/org/apache/cassandra/db/DirectoriesTest.java|No|
|14|test/unit/org/apache/cassandra/config/DatabaseDescriptorTest.java|No|
|12|test/unit/org/apache/cassandra/service/paxos/ContentionStrategyTest.java|No|
|12|test/simulator/main/org/apache/cassandra/simulator/OrderOn.java|No|
|11|test/unit/org/apache/cassandra/transport/ProtocolErrorTest.java|No|
|11|test/unit/org/apache/cassandra/io/util/FileTest.java|No|
|10|test/distributed/org/apache/cassandra/distributed/test/ReprepareTestBase.java|No|
|10|test/distributed/org/apache/cassandra/distributed/test/DistributedRepairUtils.java|No|
|9|test/unit/org/apache/cassandra/streaming/StreamSessionTest.java|No|
|9|test/unit/org/apache/cassandra/locator/ReplicaCollectionTest.java|No|
|9|test/burn/org/apache/cassandra/net/ConnectionBurnTest.java|No|
|8|test/burn/org/apache/cassandra/net/Verifier.java|No|
|7|test/unit/org/apache/cassandra/utils/concurrent/RefCountedTest.java|No|
|7|test/unit/org/apache/cassandra/index/CustomIndexTest.java|No|
|7|test/unit/org/apache/cassandra/db/DigestTest.java|No|
|7|test/unit/org/apache/cassandra/config/StartupCheckOptionsTest.java|No|
|7|test/simulator/main/org/apache/cassandra/simulator/systems/SimulatedTime.java|No|
|7|test/simulator/main/org/apache/cassandra/simulator/systems/InterceptingExecutor.java|No|
|7|test/simulator/main/org/apache/cassandra/simulator/Action.java|No|
|7|test/microbench/org/apache/cassandra/test/microbench/btree/Megamorphism.java|No|
|7|test/harry/main/org/apache/cassandra/harry/gen/EntropySource.java|No|
|6|test/unit/org/apache/cassandra/utils/concurrent/SemaphoreTest.java|No|
|6|test/unit/org/apache/cassandra/utils/Generators.java|No|
|6|test/unit/org/apache/cassandra/dht/BootStrapperTest.java|No|
|6|test/unit/org/apache/cassandra/db/marshal/CollectionTypeTest.java|No|
|6|test/simulator/main/org/apache/cassandra/simulator/systems/SimulatedExecution.java|No|
|6|test/simulator/main/org/apache/cassandra/simulator/systems/InterceptingMonitors.java|No|
|5|test/unit/org/apache/cassandra/utils/btree/BTreeTest.java|No|
|5|test/unit/org/apache/cassandra/service/StorageServiceTest.java|No|
|5|test/unit/org/apache/cassandra/security/CustomSslContextFactoryConfigTest.java|No|
|5|test/unit/org/apache/cassandra/net/BufferPoolAllocatorTest.java|No|
|5|test/unit/org/apache/cassandra/io/sstable/CQLSSTableWriterTest.java|No|
|5|test/unit/org/apache/cassandra/index/sai/cql/CollectionIndexingTest.java|No|
|5|test/simulator/main/org/apache/cassandra/simulator/ActionList.java|No|
|5|test/long/org/apache/cassandra/db/commitlog/CommitLogStressTest.java|No|
|5|test/distributed/org/apache/cassandra/distributed/test/MessageFiltersTest.java|No|
|4|test/unit/org/apache/cassandra/service/snapshot/SnapshotManifestTest.java|No|
|4|test/unit/org/apache/cassandra/net/proxy/ProxyHandlerTest.java|No|
|4|test/unit/org/apache/cassandra/net/TestChannel.java|No|
|4|test/unit/org/apache/cassandra/net/MessageSerializationPropertyTest.java|No|
|4|test/unit/org/apache/cassandra/index/sai/disk/v1/bbtree/BlockBalancedTreeIndexBuilder.java|No|
|4|test/unit/org/apache/cassandra/config/EncryptionOptionsEqualityTest.java|No|
|4|test/unit/org/apache/cassandra/concurrent/DebuggableThreadPoolExecutorTest.java|No|
|4|test/unit/accord/utils/Property.java|No|
|4|test/simulator/main/org/apache/cassandra/simulator/Ordered.java|No|
|4|test/simulator/main/org/apache/cassandra/simulator/Actions.java|No|
|4|test/harry/main/org/apache/cassandra/harry/util/ThrowingRunnable.java|No|
|4|test/harry/main/org/apache/cassandra/harry/runner/HarryRunner.java|No|
|4|test/distributed/org/apache/cassandra/distributed/test/log/CMSTestBase.java|No|
|4|test/distributed/org/apache/cassandra/distributed/test/RepairCoordinatorNeighbourDown.java|No|
|4|test/distributed/org/apache/cassandra/distributed/impl/InstanceConfig.java|No|
|4|test/burn/org/apache/cassandra/transport/DriverBurnTest.java|No|
|3|test/unit/org/apache/cassandra/utils/bytecomparable/ByteSourceConversionTest.java|No|
|3|test/unit/org/apache/cassandra/utils/bytecomparable/ByteSourceComparisonTest.java|No|
|3|test/unit/org/apache/cassandra/utils/AssertionUtils.java|No|
|3|test/unit/org/apache/cassandra/tcm/transformations/PrepareLeaveTest.java|No|
|3|test/unit/org/apache/cassandra/service/snapshot/MetadataSnapshotsTest.java|No|
|3|test/unit/org/apache/cassandra/service/paxos/uncommitted/UncommittedTableDataTest.java|No|
|3|test/unit/org/apache/cassandra/security/SSLFactoryTest.java|No|
|3|test/unit/org/apache/cassandra/index/sasi/SASIIndexTest.java|No|
|3|test/unit/org/apache/cassandra/index/sai/disk/v1/SorterTest.java|No|
|3|test/unit/org/apache/cassandra/db/rows/ThrottledUnfilteredIteratorTest.java|No|
|3|test/unit/org/apache/cassandra/db/guardrails/GuardrailMinimumReplicationFactorTest.java|No|
|3|test/unit/org/apache/cassandra/db/guardrails/GuardrailMaximumReplicationFactorTest.java|No|
|3|test/unit/org/apache/cassandra/db/compaction/LeveledCompactionStrategyTest.java|No|
|3|test/unit/org/apache/cassandra/db/commitlog/CommitLogReaderTest.java|No|
|3|test/unit/org/apache/cassandra/db/SerializationHeaderTest.java|No|
|3|test/unit/org/apache/cassandra/concurrent/SEPExecutorTest.java|No|
|3|test/unit/org/apache/cassandra/CassandraIsolatedJunit4ClassRunner.java|No|
|3|test/simulator/test/org/apache/cassandra/simulator/test/SimulatedVisitExectuor.java|No|
|3|test/simulator/main/org/apache/cassandra/simulator/systems/SimulatedActionConsumer.java|No|
|3|test/simulator/main/org/apache/cassandra/simulator/systems/SimulatedActionCallable.java|No|
|3|test/simulator/main/org/apache/cassandra/simulator/cluster/ClusterActions.java|No|
|3|test/simulator/main/org/apache/cassandra/simulator/RunnableActionScheduler.java|No|
|3|test/simulator/main/org/apache/cassandra/simulator/OrderedOn.java|No|
|3|test/simulator/asm/org/apache/cassandra/simulator/asm/MethodLogger.java|No|
|3|test/harry/main/org/apache/cassandra/harry/util/ByteUtils.java|No|
|3|test/harry/main/org/apache/cassandra/harry/tracker/DataTracker.java|No|
|3|test/distributed/org/apache/cassandra/distributed/test/log/QuorumIntersectionSimulatorTest.java|No|
|3|test/distributed/org/apache/cassandra/distributed/impl/Instance.java|No|
|2|test/unit/org/apache/cassandra/utils/btree/BTreeMapGuavaTest.java|No|
|2|test/unit/org/apache/cassandra/utils/AssertUtil.java|No|
|2|test/unit/org/apache/cassandra/tools/AuditLogViewerTest.java|No|
|2|test/unit/org/apache/cassandra/tcm/sequences/ProgressBarrierTest.java|No|
|2|test/unit/org/apache/cassandra/service/reads/repair/TestableReadRepair.java|No|
|2|test/unit/org/apache/cassandra/security/DummySslContextFactoryImpl.java|No|
|2|test/unit/org/apache/cassandra/security/CustomSslContextFactoryInvalidConfigTest.java|No|
|2|test/unit/org/apache/cassandra/repair/consistent/LocalSessionTest.java|No|
|2|test/unit/org/apache/cassandra/repair/consistent/CoordinatorMessagingTest.java|No|
|2|test/unit/org/apache/cassandra/net/ConnectionTest.java|No|
|2|test/unit/org/apache/cassandra/locator/SimpleStrategyTest.java|No|
|2|test/unit/org/apache/cassandra/io/util/BufferedDataOutputStreamTest.java|No|
|2|test/unit/org/apache/cassandra/io/sstable/metadata/MetadataSerializerTest.java|No|
|2|test/unit/org/apache/cassandra/index/sasi/utils/LongIteratorTest.java|No|
|2|test/unit/org/apache/cassandra/index/sasi/disk/TokenTreeTest.java|No|
|2|test/unit/org/apache/cassandra/index/sai/memory/VectorMemoryIndexTest.java|No|
|2|test/unit/org/apache/cassandra/dht/tokenallocator/TokenAllocationTest.java|No|
|2|test/unit/org/apache/cassandra/db/rows/UnfilteredRowsGenerator.java|No|
|2|test/unit/org/apache/cassandra/db/rows/UnfilteredRowIteratorsMergeTest.java|No|
|2|test/unit/org/apache/cassandra/db/marshal/CompositeAndTupleTypesTest.java|No|
|2|test/unit/org/apache/cassandra/db/marshal/CollectionTypesTest.java|No|
|2|test/unit/org/apache/cassandra/db/compaction/CompactionsTest.java|No|
|2|test/unit/org/apache/cassandra/db/commitlog/CommitLogInitWithExceptionTest.java|No|
|2|test/unit/org/apache/cassandra/db/SecondaryIndexTest.java|No|
|2|test/unit/org/apache/cassandra/db/ColumnFamilyStoreTest.java|No|
|2|test/unit/org/apache/cassandra/db/ColumnFamilyMetricTest.java|No|
|2|test/unit/org/apache/cassandra/cql3/validation/operations/SelectTest.java|No|
|2|test/unit/accord/utils/Gen.java|No|
|2|test/simulator/test/org/apache/cassandra/simulator/test/HarrySimulatorTest.java|No|
|2|test/simulator/main/org/apache/cassandra/simulator/systems/SimulatedActionTask.java|No|
|2|test/simulator/main/org/apache/cassandra/simulator/systems/NotifyThreadPaused.java|No|
|2|test/simulator/main/org/apache/cassandra/simulator/systems/InterceptibleThreadFactory.java|No|
|2|test/simulator/main/org/apache/cassandra/simulator/systems/InterceptedWait.java|No|
|2|test/simulator/main/org/apache/cassandra/simulator/SimulationRunner.java|No|
|2|test/simulator/asm/org/apache/cassandra/simulator/asm/InterceptAgent.java|No|
|2|test/microbench/org/apache/cassandra/test/microbench/btree/BTreeUpdateBench.java|No|
|2|test/microbench/org/apache/cassandra/test/microbench/btree/AtomicBTreePartitionUpdateBench.java|No|
|2|test/microbench/org/apache/cassandra/test/microbench/MutationBench.java|No|
|2|test/microbench/org/apache/cassandra/test/microbench/BatchStatementBench.java|No|
|2|test/long/org/apache/cassandra/db/compaction/LongCompactionsTest.java|No|
|2|test/harry/main/org/apache/cassandra/harry/dsl/ReplayingHistoryBuilder.java|No|
|2|test/distributed/org/apache/cassandra/distributed/test/log/SimulatedOperation.java|No|
|2|test/distributed/org/apache/cassandra/distributed/test/log/FetchLogFromPeersTest.java|No|
|2|test/distributed/org/apache/cassandra/distributed/test/log/CoordinatorPathTestBase.java|No|
|2|test/distributed/org/apache/cassandra/distributed/test/log/CoordinatorPathTest.java|No|
|2|test/distributed/org/apache/cassandra/distributed/test/TestBaseImpl.java|No|
|2|test/distributed/org/apache/cassandra/distributed/test/SnapshotsTest.java|No|
|2|test/distributed/org/apache/cassandra/distributed/test/RepairDigestTrackingTest.java|No|
|2|test/distributed/org/apache/cassandra/distributed/test/RepairCoordinatorFailingMessageTest.java|No|
|2|test/distributed/org/apache/cassandra/distributed/test/RepairCoordinatorBase.java|No|
|2|test/distributed/org/apache/cassandra/distributed/test/NetworkTopologyTest.java|No|
|2|test/distributed/org/apache/cassandra/distributed/mock/nodetool/InternalNodeProbeFactory.java|No|
|2|test/distributed/org/apache/cassandra/distributed/impl/IsolatedJmx.java|No|
|2|test/distributed/org/apache/cassandra/distributed/api/IClassTransformer.java|No|
|2|test/burn/org/apache/cassandra/utils/LongBTreeTest.java|No|
|2|test/burn/org/apache/cassandra/net/Connection.java|No|
|2|test/burn/org/apache/cassandra/net/BytesInFlightController.java|No|
|1|test/unit/org/apache/cassandra/utils/vint/VIntCodingTest.java|No|
|1|test/unit/org/apache/cassandra/utils/concurrent/NonBlockingRateLimiterTest.java|No|
|1|test/unit/org/apache/cassandra/utils/btree/BTreeSetGuavaTest.java|No|
|1|test/unit/org/apache/cassandra/utils/btree/BTreeBiMapGuavaTest.java|No|
|1|test/unit/org/apache/cassandra/utils/ResetableIterator.java|No|
|1|test/unit/org/apache/cassandra/utils/FixedMonotonicClock.java|No|
|1|test/unit/org/apache/cassandra/utils/CassandraVersionTest.java|No|
|1|test/unit/org/apache/cassandra/utils/ByteBufferUtilTest.java|No|
|1|test/unit/org/apache/cassandra/utils/AbstractTypeGenerators.java|No|
|1|test/unit/org/apache/cassandra/transport/ProtocolNegotiationTest.java|No|
|1|test/unit/org/apache/cassandra/tools/nodetool/stats/StatsTableComparatorTest.java|No|
|1|test/unit/org/apache/cassandra/streaming/compression/CompressedInputStreamTest.java|No|
|1|test/unit/org/apache/cassandra/service/paxos/uncommitted/PaxosBallotTrackerTest.java|No|
|1|test/unit/org/apache/cassandra/service/StartupChecksTest.java|No|
|1|test/unit/org/apache/cassandra/service/ClientStateTest.java|No|
|1|test/unit/org/apache/cassandra/service/ActiveRepairServiceTest.java|No|
|1|test/unit/org/apache/cassandra/service/AbstractFilesystemOwnershipCheckTest.java|No|
|1|test/unit/org/apache/cassandra/serializers/SimpleDateSerializerTest.java|No|
|1|test/unit/org/apache/cassandra/security/PEMReaderTest.java|No|
|1|test/unit/org/apache/cassandra/security/PEMJKSSslContextFactoryConfigTest.java|No|
|1|test/unit/org/apache/cassandra/security/DefaultSslContextFactoryTest.java|No|
|1|test/unit/org/apache/cassandra/schema/IndexMetadataTest.java|No|
|1|test/unit/org/apache/cassandra/repair/messages/RepairMessageSerializationsTest.java|No|
|1|test/unit/org/apache/cassandra/repair/ValidationTaskTest.java|No|
|1|test/unit/org/apache/cassandra/repair/FailingRepairFuzzTest.java|No|
|1|test/unit/org/apache/cassandra/repair/FailedAckTest.java|No|
|1|test/unit/org/apache/cassandra/net/proxy/InboundProxyHandler.java|No|
|1|test/unit/org/apache/cassandra/metrics/TableMetricsTest.java|No|
|1|test/unit/org/apache/cassandra/locator/ReplicaPlansTest.java|No|
|1|test/unit/org/apache/cassandra/io/sstable/VerifyTest.java|No|
|1|test/unit/org/apache/cassandra/io/sstable/SSTableZeroCopyWriterTest.java|No|
|1|test/unit/org/apache/cassandra/io/sstable/SSTableUtils.java|No|
|1|test/unit/org/apache/cassandra/io/sstable/SSTableReaderTest.java|No|
|1|test/unit/org/apache/cassandra/io/sstable/SSTableLoaderTest.java|No|
|1|test/unit/org/apache/cassandra/io/sstable/LegacySSTableTest.java|No|
|1|test/unit/org/apache/cassandra/io/sstable/DescriptorTest.java|No|
|1|test/unit/org/apache/cassandra/io/DiskSpaceMetricsTest.java|No|
|1|test/unit/org/apache/cassandra/inject/Expression.java|No|
|1|test/unit/org/apache/cassandra/inject/ActionBuilder.java|No|
|1|test/unit/org/apache/cassandra/index/sasi/utils/RangeUnionIteratorTest.java|No|
|1|test/unit/org/apache/cassandra/index/sasi/utils/RangeIntersectionIteratorTest.java|No|
|1|test/unit/org/apache/cassandra/index/sasi/utils/MappedBufferTest.java|No|
|1|test/unit/org/apache/cassandra/index/sai/cql/VectorLocalTest.java|No|
|1|test/unit/org/apache/cassandra/gms/NewGossiperTest.java|No|
|1|test/unit/org/apache/cassandra/gms/ArrayBackedBoundedStatsTest.java|No|
|1|test/unit/org/apache/cassandra/fql/FullQueryLoggerTest.java|No|
|1|test/unit/org/apache/cassandra/diag/DiagnosticEventServiceTest.java|No|
|1|test/unit/org/apache/cassandra/dht/SplitterTest.java|No|
|1|test/unit/org/apache/cassandra/dht/LengthPartitioner.java|No|
|1|test/unit/org/apache/cassandra/dht/KeyCollisionTest.java|No|
|1|test/unit/org/apache/cassandra/db/virtual/SystemPropertiesTableTest.java|No|
|1|test/unit/org/apache/cassandra/db/virtual/StreamingVirtualTableTest.java|No|
|1|test/unit/org/apache/cassandra/db/virtual/JmxPermissionsCacheKeysTableTest.java|No|
|1|test/unit/org/apache/cassandra/db/virtual/GossipInfoTableTest.java|No|
|1|test/unit/org/apache/cassandra/db/streaming/EntireSSTableStreamConcurrentComponentMutationTest.java|No|
|1|test/unit/org/apache/cassandra/db/streaming/ComponentManifestTest.java|No|
|1|test/unit/org/apache/cassandra/db/streaming/CassandraStreamHeaderTest.java|No|
|1|test/unit/org/apache/cassandra/db/streaming/CassandraEntireSSTableStreamWriterTest.java|No|
|1|test/unit/org/apache/cassandra/db/rows/UnfilteredRowIteratorsTest.java|No|
|1|test/unit/org/apache/cassandra/db/repair/PendingAntiCompactionTest.java|No|
|1|test/unit/org/apache/cassandra/db/marshal/CompositeTypeTest.java|No|
|1|test/unit/org/apache/cassandra/db/guardrails/GuardrailTester.java|No|
|1|test/unit/org/apache/cassandra/db/compaction/writers/CompactionAwareWriterTest.java|No|
|1|test/unit/org/apache/cassandra/db/compaction/PartialCompactionsTest.java|No|
|1|test/unit/org/apache/cassandra/db/compaction/OneCompactionTest.java|No|
|1|test/unit/org/apache/cassandra/db/compaction/CompactionsPurgeTest.java|No|
|1|test/unit/org/apache/cassandra/db/compaction/CompactionsBytemanTest.java|No|
|1|test/unit/org/apache/cassandra/db/commitlog/CommitLogDescriptorTest.java|No|
|1|test/unit/org/apache/cassandra/db/RepairedDataInfoTest.java|No|
|1|test/unit/org/apache/cassandra/db/ReadResponseTest.java|No|
|1|test/unit/org/apache/cassandra/db/ReadCommandTest.java|No|
|1|test/unit/org/apache/cassandra/db/KeyspaceTest.java|No|
|1|test/unit/org/apache/cassandra/db/ImportTest.java|No|
|1|test/unit/org/apache/cassandra/db/ClusteringHeapSizeTest.java|No|
|1|test/unit/org/apache/cassandra/db/CellSpecTest.java|No|
|1|test/unit/org/apache/cassandra/cql3/validation/operations/CreateTest.java|No|
|1|test/unit/org/apache/cassandra/cql3/validation/operations/AutoSnapshotTest.java|No|
|1|test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java|No|
|1|test/unit/org/apache/cassandra/cql3/validation/entities/udfverify/ClassWithStaticInnerClass.java|No|
|1|test/unit/org/apache/cassandra/cql3/validation/entities/udfverify/ClassWithInnerClass2.java|No|
|1|test/unit/org/apache/cassandra/cql3/validation/entities/udfverify/ClassWithInnerClass.java|No|
|1|test/unit/org/apache/cassandra/cql3/validation/entities/TupleTypeTest.java|No|
|1|test/unit/org/apache/cassandra/cql3/functions/MathFctsTest.java|No|
|1|test/unit/org/apache/cassandra/cql3/conditions/ColumnConditionTest.java|No|
|1|test/unit/org/apache/cassandra/cql3/KeywordSplitTest.java|No|
|1|test/unit/org/apache/cassandra/cql3/KeywordSplit1Test.java|No|
|1|test/unit/org/apache/cassandra/cql3/DistinctQueryPagingTest.java|No|
|1|test/unit/org/apache/cassandra/cql3/DeleteTest.java|No|
|1|test/unit/org/apache/cassandra/cql3/CQLTester.java|No|
|1|test/unit/org/apache/cassandra/config/CassandraRelevantPropertiesTest.java|No|
|1|test/unit/org/apache/cassandra/audit/AuditLoggerTest.java|No|
|1|test/unit/org/apache/cassandra/Util.java|No|
|1|test/unit/org/apache/cassandra/ConsoleAppender.java|No|
|1|test/unit/accord/utils/DefaultRandom.java|No|
|1|test/simulator/main/org/apache/cassandra/simulator/systems/SimulatedBallots.java|No|
|1|test/simulator/main/org/apache/cassandra/simulator/systems/NonInterceptible.java|No|
|1|test/simulator/main/org/apache/cassandra/simulator/paxos/PairOfSequencesPaxosSimulation.java|No|
|1|test/simulator/main/org/apache/cassandra/simulator/paxos/HistoryChecker.java|No|
|1|test/simulator/main/org/apache/cassandra/simulator/harry/HarryValidatingQuery.java|No|
|1|test/simulator/main/org/apache/cassandra/simulator/debug/Reconcile.java|No|
|1|test/simulator/main/org/apache/cassandra/simulator/cluster/OnInstanceFlushAndCleanup.java|No|
|1|test/simulator/main/org/apache/cassandra/simulator/RandomSource.java|No|
|1|test/simulator/main/org/apache/cassandra/simulator/FutureActionScheduler.java|No|
|1|test/simulator/main/org/apache/cassandra/simulator/Debug.java|No|
|1|test/simulator/main/org/apache/cassandra/simulator/ActionSchedule.java|No|
|1|test/simulator/main/org/apache/cassandra/simulator/ActionListener.java|No|
|1|test/simulator/asm/org/apache/cassandra/simulator/asm/InterceptClasses.java|No|
|1|test/microbench/org/apache/cassandra/test/microbench/btree/BTreeTransformBench.java|No|
|1|test/microbench/org/apache/cassandra/test/microbench/VIntCodingBench.java|No|
|1|test/microbench/org/apache/cassandra/test/microbench/FastThreadLocalBench.java|No|
|1|test/long/org/apache/cassandra/utils/LongBloomFilterTest.java|No|
|1|test/long/org/apache/cassandra/io/compress/CompressorPerformance.java|No|
|1|test/long/org/apache/cassandra/cql3/CorruptionTest.java|No|
|1|test/harry/main/org/apache/cassandra/harry/sut/TokenPlacementModel.java|No|
|1|test/harry/main/org/apache/cassandra/harry/sut/SystemUnderTest.java|No|
|1|test/harry/main/org/apache/cassandra/harry/runner/StagedRunner.java|No|
|1|test/harry/main/org/apache/cassandra/harry/runner/Runner.java|No|
|1|test/harry/main/org/apache/cassandra/harry/gen/DataGenerators.java|No|
|1|test/distributed/org/apache/cassandra/fuzz/harry/runner/LockingDataTrackerTest.java|No|
|1|test/distributed/org/apache/cassandra/fuzz/harry/integration/op/RowVisitorTest.java|No|
|1|test/distributed/org/apache/cassandra/fuzz/harry/integration/model/QuiescentCheckerIntegrationTest.java|No|
|1|test/distributed/org/apache/cassandra/fuzz/harry/integration/model/ModelTestBase.java|No|
|1|test/distributed/org/apache/cassandra/fuzz/harry/integration/ddl/SchemaGenTest.java|No|
|1|test/distributed/org/apache/cassandra/distributed/upgrade/MixedModeMessageForwardTest.java|No|
|1|test/distributed/org/apache/cassandra/distributed/test/thresholds/TombstoneCountWarningTest.java|No|
|1|test/distributed/org/apache/cassandra/distributed/test/thresholds/AbstractClientSizeWarning.java|No|
|1|test/distributed/org/apache/cassandra/distributed/test/ring/DecommissionTest.java|No|
|1|test/distributed/org/apache/cassandra/distributed/test/metrics/StreamingMetricsTest.java|No|
|1|test/distributed/org/apache/cassandra/distributed/test/log/PlacementSimulator.java|No|
|1|test/distributed/org/apache/cassandra/distributed/test/log/FuzzTestBase.java|No|
|1|test/distributed/org/apache/cassandra/distributed/test/RepairCoordinatorFast.java|No|
|1|test/distributed/org/apache/cassandra/distributed/test/PaxosRepairTest.java|No|
|1|test/distributed/org/apache/cassandra/distributed/test/MultipleDataDirectoryTest.java|No|
|1|test/distributed/org/apache/cassandra/distributed/test/ClusterStorageUsageTest.java|No|
|1|test/distributed/org/apache/cassandra/distributed/test/CasWriteTest.java|No|
|1|test/distributed/org/apache/cassandra/distributed/test/BootstrapBinaryDisabledTest.java|No|
|1|test/distributed/org/apache/cassandra/distributed/test/AbstractEncryptionOptionsImpl.java|No|
|1|test/distributed/org/apache/cassandra/distributed/shared/Byteman.java|No|
|1|test/distributed/org/apache/cassandra/distributed/impl/InstanceKiller.java|No|
|1|test/distributed/org/apache/cassandra/distributed/impl/DirectStreamingConnectionFactory.java|No|
|1|test/distributed/org/apache/cassandra/distributed/impl/Coordinator.java|No|
|1|test/distributed/org/apache/cassandra/distributed/api/SimpleQueryResult.java|No|
|1|test/distributed/org/apache/cassandra/distributed/api/IMessage.java|No|
I'll make an attempt to create a branch tomorrow with:
* commit with the checkstyle rule changes
* a tentative commit with source code changes, just to get an idea of what the
changeset would look like.
I'll also send a proposal to the mailing list.
> Add 'LeftCurly' checkstyle rule to enforce braces on next line on build
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-19276
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19276
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Andy Tolbert
> Assignee: Andy Tolbert
> Priority: Normal
>
> It came up in a review that I had missed some style changes in
> [CASSANDRA-18857]
> (https://github.com/apache/cassandra/pull/2969#pullrequestreview-1810999533).
> Chatting with [~smiklosovic] we agreed that it would be nice if we could
> enforce this in checkstyle, so we wouldn't need to be dependent on this being
> caught in review.
> The change for this is effectively:
> {code}
> index 8b81f21281..9bd22dc1ac 100644
> --- a/.build/checkstyle.xml
> +++ b/.build/checkstyle.xml
> @@ -179,6 +179,10 @@
> <message key="matchxpath.match"
> value="'Deprecated annotation must provide 'since' value."/>
> </module>
> + <module name="LeftCurly">
> + <property name="option" value="nl"/>
> + <property name="tokens"
> value="ANNOTATION_DEF,CLASS_DEF,CTOR_DEF,ENUM_CONSTANT_DEF,INTERFACE_DEF,LITERAL_CASE,LITERAL_CATCH,LITERAL_DEFAULT,LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_FOR,LITERAL_IF,LITERAL_SWITCH,LITERAL_SYNCHRONIZED,LITERAL_TRY,LITERAL_WHILE,METHOD_DEF,OBJBLOCK,STATIC_INIT,RECORD_DEF,COMPACT_CTOR_DEF"/>
> + </module>
> </module>
> </module>
> {code}
> Notably, we would allow braces on the same lines for lambdas as per the
> [project
> guidelines|https://cassandra.apache.org/_/development/code_style.html] on
> code formatting:
> {quote}
> {{{}} and {{}}} are placed on a new line except when empty or opening a
> multi-line lambda expression. Braces may be elided to a depth of one if the
> condition or loop guards a single expression.
> {quote}
> There are 594 violations and 211 source files that would need to be adjusted.
> I may play with the rules a little bit more to get this right.
> I would like to propose that we change all files that are not imported from
> other projects (there are a few, such as
> src/java/org/apache/cassandra/utils/obs/BitUtil.java, which we can suppress
> changes for), but we would change others.
> I'll make a patch with the changes send a small proposal to the mailing list
> as it could be disruptive to make a bunch of tiny changes, and depending on
> timing there may be a better time to make a change like this.
> We should make this change only on trunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
