[ 
https://issues.apache.org/jira/browse/CASSANDRA-13855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810577#comment-17810577
 ] 

Stefan Miklosovic commented on CASSANDRA-13855:
-----------------------------------------------

[~claude] I have prepared a PR where I refactored it a little bit (1).

There is already existing HTTP connector which we coded as part of 
CASSANDRA-16555 and coding up another connector is just not necessary and it is 
better if we reuse what is already there. I have reshuffled the code little bit 
to reuse that code from snitches to seed providers so now we use it at both 
places.

I have also added tests which are testing this against mocked HTTP server which 
will be started as part of the tests (also introduced in CASSANDRA-16555). 
Hence, we are testing the real HTTP communication ...

If you are OK with this set of changes, I can take it from here, run the builds 
etc and invite another committer to formally review that as well.

(1) https://github.com/Claudenw/cassandra/pull/10

> URL Seed provider
> -----------------
>
>                 Key: CASSANDRA-13855
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13855
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Legacy/Coordination, Legacy/Core
>            Reporter: Jon Haddad
>            Assignee: Claude Warren
>            Priority: Low
>              Labels: lhf
>             Fix For: 5.x
>
>         Attachments: 0001-Add-URL-Seed-Provider-trunk.txt, signature.asc, 
> signature.asc, signature.asc
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Seems like including a dead simple seed provider that can fetch from a URL, 1 
> line per seed, would be useful.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to