absurdfarce commented on code in PR #1914:
URL: 
https://github.com/apache/cassandra-java-driver/pull/1914#discussion_r1499604687


##########
changelog/README.md:
##########
@@ -21,6 +21,16 @@ under the License.
 
 <!-- Note: contrary to 3.x, insert new entries *first* in their section -->
 
+### 4.18.0
+
+- [improvement] PR 1689: Add support for publishing percentile time series for 
the histogram metrics (nparaddi-walmart)

Review Comment:
   Yeah, both of the commits in question for this change came in as 
contributions from the community and weren't tied to any existing ticket 
(either JAVA or CASSANDRA).
   
   Honestly I'm kind of in two minds about the idea of connecting everything to 
a CASSANDRA ticket @tolbertam.  We tried to do something like that for a while 
on the Java side and I'm not sure there's a huge benefit.  The PR gives you an 
identifier/address/URL you can use to refer to the change and any discussion 
can happen on the PR itself... in a lot of ways it's similar to having a JIRA 
ticket.
   
   I don't have super-strong feelings on the matter so I'm open to pursuing a 
policy of tying any change to a CASSANDRA ticket... but it's not immediately 
clear to me it offers the benefits it appears to.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to