JeetKunDoug commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1541488419
##########
cassandra-four-zero/src/main/java/org/apache/cassandra/bridge/SSTableWriterImplementation.java:
##########
@@ -81,17 +85,23 @@ static CQLSSTableWriter.Builder configureBuilder(String
inDirectory,
String createStatement,
String insertStatement,
int bufferSizeMB,
+ Set<String> udts,
IPartitioner
cassPartitioner)
{
- return CQLSSTableWriter
- .builder()
- .inDirectory(inDirectory)
- .forTable(createStatement)
- .withPartitioner(cassPartitioner)
- .using(insertStatement)
- // The data frame to write is always sorted,
- // see
org.apache.cassandra.spark.bulkwriter.CassandraBulkSourceRelation.insert
- .sorted()
- .withMaxSSTableSizeInMiB(bufferSizeMB);
+ CQLSSTableWriter.Builder builder = CQLSSTableWriter
+ .builder()
+ .inDirectory(inDirectory)
+ .forTable(createStatement)
+ .withPartitioner(cassPartitioner)
+ .using(insertStatement)
+ // The data frame to write is
always sorted,
+ // see
org.apache.cassandra.spark.bulkwriter.CassandraBulkSourceRelation.insert
+ .sorted()
+
.withMaxSSTableSizeInMiB(bufferSizeMB);
+ for (String udt : udts)
+ {
+ builder.withType(udt);
+ }
+ return builder;
Review Comment:
I'm not sure why this is any different/better than the existing code - just
less indented?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
