arjunashok commented on code in PR #51:
URL:
https://github.com/apache/cassandra-analytics/pull/51#discussion_r1581459225
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java:
##########
@@ -135,12 +135,11 @@ private void publishInitialJobStats(String sparkVersion)
{
Map<String, String> initialJobStats = new HashMap<String, String>() //
type declaration required to compile with java8
{{
- put("jobId", jobInfo.getId().toString());
put("sparkVersion", sparkVersion);
- put("keyspace", jobInfo.getId().toString());
- put("table", jobInfo.getId().toString());
+ put("keyspace", jobInfo.getId());
Review Comment:
Yes, probably got mixed-up during rebase. Corrected.
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java:
##########
@@ -135,12 +135,11 @@ private void publishInitialJobStats(String sparkVersion)
{
Map<String, String> initialJobStats = new HashMap<String, String>() //
type declaration required to compile with java8
{{
- put("jobId", jobInfo.getId().toString());
put("sparkVersion", sparkVersion);
- put("keyspace", jobInfo.getId().toString());
- put("table", jobInfo.getId().toString());
+ put("keyspace", jobInfo.getId());
+ put("table", jobInfo.qualifiedTableName().toString());
Review Comment:
Yes, probably got mixed-up during rebase. Corrected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
