[ https://issues.apache.org/jira/browse/CASSANDRA-19619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Caleb Rackliffe updated CASSANDRA-19619: ---------------------------------------- Status: Ready to Commit (was: Review In Progress) 5.0 CI looks fine. (see [^ci_summary-1.html] ) +1 > Enforce contract for internal metrics naming > -------------------------------------------- > > Key: CASSANDRA-19619 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19619 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics > Reporter: Maxim Muzafarov > Assignee: Maxim Muzafarov > Priority: Normal > Fix For: 5.0-rc, 5.0.x, 5.x > > Attachments: ci_summary-1.html, ci_summary.html > > Time Spent: 20m > Remaining Estimate: 0h > > Metrics have their internal representation which uniquely identifies a > particular metric name. The name is formed as {{<metric group>.<metric > type>.<metric name>.<metric scope>}}. For some metrics, the scope includes a > metric name that is not necessary for uniqueness, this can be simplified. > For example, > {code} > // AS IS > org.apache.cassandra.metrics.StorageAttachedIndex.BalancedTreeIntersectionEarlyExits.my_keyspace.my_table.ColumnQueryMetrics.BalancedTreeIntersectionEarlyExits > // TO BE > org.apache.cassandra.metrics.StorageAttachedIndex.BalancedTreeIntersectionEarlyExits.my_keyspace.my_table.ColumnQueryMetrics > {code} > The metrics are filtered based on knowledge of how they are formatted, so > having a metric scope without a built-in metric name also simplifies the way > we filter metrics. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org