[ https://issues.apache.org/jira/browse/CASSANDRA-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131739#comment-13131739 ]
Jonathan Ellis commented on CASSANDRA-3388: ------------------------------------------- Ah, I get it now. I was confused by the description of "making this attribute more usable through JMX." > StorageService.setMode() is used inconsistently > ----------------------------------------------- > > Key: CASSANDRA-3388 > URL: https://issues.apache.org/jira/browse/CASSANDRA-3388 > Project: Cassandra > Issue Type: Bug > Components: Core > Affects Versions: 1.0.0 > Reporter: Tyler Hobbs > Priority: Trivial > > {{StorageService.setMode()}}, which ends up setting the OperationMode > attribute of the related mbean, is used inconsistently. In most places, it's > used like "{{setMode("MODE: details")}}, but in a few places, it's used more > like a normal log message. > To make this attribute more usable through JMX, {{setMode()}} should have a > signature like {{setMode(mode, details)}}, where the mode parameter could be > an enum (or even just a string, the main thing is just being consistent). > The OperationMode JMX attribute should definitely remain a string, though. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira