[ 
https://issues.apache.org/jira/browse/CASSANDRA-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147150#comment-13147150
 ] 

Sylvain Lebresne commented on CASSANDRA-1740:
---------------------------------------------

* In CompactionInfo.Holder, stop should likely be volatile
* I'm not fond of using exceptions (StoppedException) for something that is not 
exceptional or an error in the first place. But in particular, throwing the 
exception will result in a 'Fatal error' in the log, which tends to scare 
people, so that's another reason to avoid it.
* Stopping an AutoSavingCache task will leave a tmp file around.
* Doesn't make much sense to me to have StoppedException extend IOException 
since it's not. If the only goal is to avoid having to add a new checked 
exception, then making it a RuntimeException is imo better. But as said above, 
I think we shouldn't use exception for that anyway.

                
> Nodetool commands to query and stop compaction, repair, cleanup and scrub
> -------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1740
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1740
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Chip Salzenberg
>            Assignee: Vijay
>            Priority: Minor
>              Labels: compaction
>             Fix For: 1.0.3
>
>         Attachments: 0001-Patch-to-Stop-compactions.patch, 
> CASSANDRA-1740.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The only way to stop compaction, repair, cleanup, or scrub in progress is to 
> stop and restart the entire Cassandra server.  Please provide nodetool 
> commands to query whether such things are running, and stop them if they are.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to