[ https://issues.apache.org/jira/browse/CASSANDRA-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151359#comment-13151359 ]
Sylvain Lebresne commented on CASSANDRA-3406: --------------------------------------------- bq. Can you split it into refactor + newscrub patches? Will do. bq. (Incidently I think having snapshot on the upgrade path is a Very Good Thing Indeed, although scrub isn't quite the best way to do that.) I couldn't agree more but it must be before the upgrade, scrub is run after, so not the good place at all. > Create a nodetool upgrade_sstables to avoid using scrubs for tasks it wasn't > intended to. > ----------------------------------------------------------------------------------------- > > Key: CASSANDRA-3406 > URL: https://issues.apache.org/jira/browse/CASSANDRA-3406 > Project: Cassandra > Issue Type: New Feature > Components: Core > Affects Versions: 1.0.0 > Reporter: Sylvain Lebresne > Assignee: Sylvain Lebresne > Priority: Trivial > Fix For: 1.0.4 > > Attachments: 3406.patch > > > Scrub was intended to check a data file is not corrupted and to try to > correct some form of corruption and discard the data when it can't repair. > But we are now using it also for: > * major upgrade, to have sstable in the new data format for streaming sake > (that one could be "fixed" independently by supporting old format during > streaming) > * to force the compaction of existing sstables after changing the compression > algorithm > We should probably provide a separate tool/command for those two last tasks > since: > * we could have a better name, like upgrade_sstables or rewrite_sstables for > that operation > * we could avoid the automatic snapshot that scrub does (and is not expected > by users for those operations) > * make it slightly quicker/simpler by avoiding the corruption detection code -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira