[ 
https://issues.apache.org/jira/browse/CASSANDRA-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173168#comment-13173168
 ] 

Brandon Williams commented on CASSANDRA-3649:
---------------------------------------------

bq. I would also like replacing tabs by spaces in the few places where tabs are 
used (again consistency) and remove all end-of-line spaces (but that's to 
please my OCD, I'll live if we don't do it).

+1

bq. Ultimately style is a very subjective thing; I, for one, prefer 
brace-on-newlines.

I don't, or at least I used to not, but I've done it for so long now because of 
this inherited style that I'm pretty used to it, so I don't have any especially 
strong feelings either way here.

bq. but changing this now means that no patch from before the refactor will 
ever apply, including everything that will be committed to some older version 
and merged up and every patches attached to JIRA at the time of the refactor

Jonathan suggested that we reformat 1.0 as well to get around this problem, 
fwiw.


                
> Code style changes, aka The Big Reformat
> ----------------------------------------
>
>                 Key: CASSANDRA-3649
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3649
>             Project: Cassandra
>          Issue Type: Wish
>          Components: Core
>            Reporter: Brandon Williams
>             Fix For: 1.2
>
>
> With a new major release coming soon and not having a ton of huge pending 
> patches that have prevented us from doing this in the past, post-freeze looks 
> like a good time to finally do this.  Mostly this will include the removal of 
> underscores in private variables, and no more brace-on-newline policy.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to