[ 
https://issues.apache.org/jira/browse/CASSANDRA-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278616#comment-13278616
 ] 

Kirk True commented on CASSANDRA-3974:
--------------------------------------

In my test case, it does go through {{RowIteratorFactory}}, but it *doesn't* go 
through line 111. In {{getReduced}} {{cached}} is always {{null}} so it calls 
the {{filter.collateColumns}} path.

So I made this naive change:

{noformat}
if (cached == null)
{
    // not cached: collate
    filter.collateColumns(returnCF, colIters, gcBefore);
    returnCF = ColumnFamilyStore.removeDeleted(returnCF, gcBefore);
}
else
{
    QueryFilter keyFilter = new QueryFilter(key, filter.path, filter.filter);
    returnCF = cfs.filterColumnFamily(cached, keyFilter, gcBefore);
}
{noformat}

Be "manually" calling {{removeDeleted}} I was able to get my columns filtered 
out as expected.

I'm pretty sure this is incomplete or just plain wrong, but I wanted to get 
your thoughts.
                
> Per-CF TTL
> ----------
>
>                 Key: CASSANDRA-3974
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3974
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Jonathan Ellis
>            Assignee: Kirk True
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: trunk-3974.txt
>
>
> Per-CF TTL would allow compaction optimizations ("drop an entire sstable's 
> worth of expired data") that we can't do with per-column.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to