[ 
https://issues.apache.org/jira/browse/CASSANDRA-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285570#comment-13285570
 ] 

Sylvain Lebresne commented on CASSANDRA-4018:
---------------------------------------------

I pushed at https://github.com/pcmanus/cassandra/commits/4018-10 an additional 
commit on top of 4018-9. It does create a ClientState for processInternal; a 
clientState object is not very expensive and it's easier than trying to hack 
the code to work without clientState imo. Another problem is that currently you 
can't do range_slice query on the system tables before the tokens are set, but 
the request was to actually read the saved token, so that thrown a 
assertionError in the TokenMetadata.ringIterator. The commit fix this by 
specializing getNaturalEndpoints for localStrategy, which is enough. But I 
would be fine if we decide that during the SystemTable loading we decide to 
stick with lower level CFStore methods to query.

Another problem is CASSANDRA-4296, so the branch should also be rebased on top 
of that (which is not the case of my github branch btw).

Even with that, I still get one last unit test failure. The problem is that the 
new 'peers' table uses row keys that are not necessarily UTF8, but the tests 
are using CollatingOrderPreservingPartitioner so this throws an exception (in 
BootStrapperTest). Not sure what's the best fix for that.
                
> Add column metadata to system columnfamilies
> --------------------------------------------
>
>                 Key: CASSANDRA-4018
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4018
>             Project: Cassandra
>          Issue Type: Improvement
>    Affects Versions: 1.1.0
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 1.2
>
>
> CASSANDRA-3792 adds this to the schema CFs; we should modernize the other 
> system CFs as well

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to