[
https://issues.apache.org/jira/browse/CASSANDRA-7028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969765#comment-13969765
]
Joshua McKenzie commented on CASSANDRA-7028:
--------------------------------------------
Ah - good call on the runtime libraries.
v4 lost the full index so file deletion failed and the diff has references to
the new .jar files which prevents it applying both with the files and without.
I've attached a v5 that cleans up some whitespace complaints and includes the
binary, both deletion and addition. We should be able to just apply this to
trunk and get all the changes - one-shot, no need to download libraries
separately and place them for the committer.
The diff syntax I used to build this was 'git diff --full-index --binary
<commit1> <commit2>'. Even w/full-index, if you don't include the binary flag
it won't generate the data that goes with your new files you've added and you
end up with an invalid patch as it has markers to add files but no binary data
to place in them.
I reran tests on linux against this just to confirm changes to resolve
HintedHandOffTest didn't munge with anything else and it all looks good on
jdk7. I'm +1 on the v5 patch; give it a run against trunk and let me know how
it works for you.
> Allow C* to compile under java 8
> --------------------------------
>
> Key: CASSANDRA-7028
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7028
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Dave Brosius
> Assignee: Dave Brosius
> Priority: Minor
> Fix For: 3.0
>
> Attachments: 7028.txt, 7028_v2.txt, 7028_v3.txt, 7028_v4.txt,
> 7028_v5.patch
>
>
> antlr 3.2 has a problem with java 8, as described here:
> http://bugs.java.com/bugdatabase/view_bug.do?bug_id=8015656
> updating to antlr 3.5.2 solves this, however they have split up the jars
> differently, which adds some changes, but also the generation of
> CqlParser.java causes a method to be too large, so i needed to split that
> method to reduce the size of it.
> (patch against trunk)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
