SbloodyS commented on a change in pull request #8387:
URL: https://github.com/apache/dolphinscheduler/pull/8387#discussion_r806437369
##########
File path:
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java
##########
@@ -1615,6 +1645,9 @@ private void killAllTasks() {
}
TaskInstance taskInstance =
processService.findTaskInstanceById(taskInstanceId);
if (taskInstance == null ||
taskInstance.getState().typeIsFinished()) {
+ if (readyToSubmitTaskQueue.size() > 0) {
Review comment:
When the task instance fails and the kill command is received in the
task retry interval. We need to clear the readyToSubmitTaskQueue to ensure that
the subsequent checks are normal.
##########
File path:
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java
##########
@@ -1437,14 +1444,10 @@ private ExecutionStatus processReadyPause() {
private ExecutionStatus getProcessInstanceState(ProcessInstance instance) {
ExecutionStatus state = instance.getState();
- if (activeTaskProcessorMaps.size() > 0 || hasRetryTaskInStandBy()) {
+ if ((activeTaskProcessorMaps.size() > 0 || hasRetryTaskInStandBy()) &&
state != ExecutionStatus.READY_STOP) {
Review comment:
This has been check in readyToSubmitTaskQueue.clear(). I'll remove this
logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
