DHBin commented on issue #8480: URL: https://github.com/apache/dolphinscheduler/issues/8480#issuecomment-1077034900
你好,@caishunfeng,在#9085的pr中，你在submitTaskInstanceToDB方法中设置了SubmitTime，但我不觉得这是一个好的解决方法，因为先保存了SubmitTime，然后在分发任务，把任务放进了队列中，当取出任务处理后再更新了一次SubmitTime，导致这值不一致。我觉得是否考虑在TaskExecutionContext中添加多一个SubmitTime字段，解决这个不一致的问题。另一个问题是，我看了下dev分支对host的处理，我有一个疑问，为什么`TaskPriorityQueueConsumer#dispatch`中不更新host了，而是在ack中更新，期待你的解答 ---- 翻译 hi, @caishunfeng, in the pr of #9085, you set the SubmitTime in the submitTaskInstanceToDB method, but I don't think this is a good solution, because the SubmitTime is saved first, and then the task is distributed and the task is put into the queue , the SubmitTime is updated once after the task is taken out and processed, resulting in inconsistent values. I think whether to consider adding one more SubmitTime field to TaskExecutionContext to solve this inconsistency problem. Another question is, I looked at the handling of the host by the dev branch. I have a question, why the host is not updated in `TaskPriorityQueueConsumer#dispatch`, but is updated in ack, looking forward to your answer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
