lasdf1234 commented on code in PR #11156:
URL: https://github.com/apache/gravitino/pull/11156#discussion_r3268335609
##########
iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java:
##########
@@ -457,11 +457,13 @@ private TableMetadataCache
loadTableMetadataCache(IcebergConfig config, Catalog
return TableMetadataCache.DUMMY;
}
- Preconditions.checkArgument(
- catalog instanceof SupportsMetadataLocation,
- "You shouldn't enable Iceberg metadata cache for the catalog %s,"
- + " because the catalog impl does not support get metadata
location.",
- catalog.name());
+ if (!(catalog instanceof SupportsMetadataLocation)) {
+ LOG.warn(
+ "Skip Iceberg table metadata cache for catalog {} because the
catalog does not support"
+ + " metadata location.",
+ catalog.name());
+ return TableMetadataCache.DUMMY;
+ }
Review Comment:
Extra modifications have been rolled back.
##########
iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/IcebergConfig.java:
##########
@@ -276,14 +277,14 @@ public class IcebergConfig extends Config implements
OverwriteDefaultConfig {
.doc("Table metadata cache implementation")
.version(ConfigConstants.VERSION_1_1_0)
.stringConf()
- .create();
+ .createWithDefault(LocalTableMetadataCache.class.getName());
public static final ConfigEntry<Integer> TABLE_METADATA_CACHE_CAPACITY =
new ConfigBuilder(IcebergConstants.TABLE_METADATA_CACHE_CAPACITY)
.doc("Table metadata cache capacity")
.version(ConfigConstants.VERSION_1_1_0)
.intConf()
- .createWithDefault(200);
+ .createWithDefault(1000);
Review Comment:
Extra modifications have been rolled back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
