roryqi commented on code in PR #11155:
URL: https://github.com/apache/gravitino/pull/11155#discussion_r3272406625
##########
common/src/main/java/org/apache/gravitino/credential/CredentialProvider.java:
##########
@@ -66,9 +66,9 @@ default boolean supportsScheme(String scheme) {
* Gets a credential based on the provided context information.
*
* @param context A context object providing necessary information for
retrieving credentials.
- * @return A Credential object containing the authentication information
needed to access a system
- * or resource. Null will be returned if no credential is available.
+ * @return An {@link Optional} containing the {@link Credential} with the
authentication
+ * information needed to access a system or resource, or {@link
Optional#empty()} if no
+ * credential is available.
*/
- @Nullable
- Credential getCredential(CredentialContext context);
+ Optional<Credential> getCredential(CredentialContext context);
}
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
