hudi-agent commented on code in PR #18472:
URL: https://github.com/apache/hudi/pull/18472#discussion_r3251638323
##########
packaging/hudi-azure-bundle/pom.xml:
##########
@@ -129,6 +156,9 @@
<resource>
<directory>src/main/resources</directory>
</resource>
+ <resource>
+ <directory>src/test/resources</directory>
Review Comment:
🤖 nit: including `src/test/resources` in the main build resources is unusual
— could you add a comment explaining why it's needed here (e.g. which runtime
config files live there that the bundle requires)?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
##########
packaging/hudi-azure-bundle/pom.xml:
##########
@@ -116,6 +142,7 @@
<exclude>META-INF/*.RSA</exclude>
<exclude>META-INF/services/javax.*</exclude>
<exclude>**/*.proto</exclude>
+ <exclude>hbase-webapps/**</exclude>
Review Comment:
🤖 nit: it might be worth adding a brief inline comment here noting which
transitive dependency pulls in `hbase-webapps/` — without it, a future reader
will wonder why HBase UI resources are being excluded from an Azure bundle.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
##########
packaging/hudi-azure-bundle/pom.xml:
##########
@@ -129,6 +156,9 @@
<resource>
<directory>src/main/resources</directory>
</resource>
+ <resource>
Review Comment:
🤖 Is there a reason to add `src/test/resources` to the main `<resources>`
block? Maven's standard layout already exposes it for the test phase, and
adding it here will package any test resources into the production shaded jar.
The sibling `hudi-aws-bundle` and `hudi-gcp-bundle` only declare
`src/main/resources`. Could you drop this entry unless something specifically
requires it?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
