[
https://issues.apache.org/jira/browse/MINIFI-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159281#comment-16159281
]
ASF GitHub Bot commented on MINIFI-339:
---------------------------------------
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137587193
--- Diff: libminifi/include/core/state/metrics/RepositoryMetrics.h ---
@@ -0,0 +1,101 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#ifndef LIBMINIFI_INCLUDE_CORE_STATE_METRICS_RepositoryMetrics_H_
+#define LIBMINIFI_INCLUDE_CORE_STATE_METRICS_RepositoryMetrics_H_
--- End diff --
Inconsistent include guard capitalization.
> Begin building controlling API to facilitate control of agents
> --------------------------------------------------------------
>
> Key: MINIFI-339
> URL: https://issues.apache.org/jira/browse/MINIFI-339
> Project: Apache NiFi MiNiFi
> Issue Type: New Feature
> Components: C++
> Reporter: marco polo
> Assignee: marco polo
> Priority: Critical
> Labels: Durability, Reliability, Statistics
>
> Begin building the controlling API in MiNiFi C++. This API will evolve and
> likely have public and private elements. As development progresses we may
> want more capabilities.
> What I want to create as a straw man will be basic control and metrics
> gathering
> -- Start
> -- Stop
> -- Pause
> -- Gather metrics
> ** Throughput of of flow components
> ** Execution time ( run time minus sleep time )
> ** Memory consumption
> -- Drain repositories
> -- Switch repository types.
> Better employ update listener within this controlling API
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
