[ https://issues.apache.org/jira/browse/MINIFI-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159290#comment-16159290 ]
ASF GitHub Bot commented on MINIFI-339: --------------------------------------- Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137879427 --- Diff: libminifi/include/processors/InvokeHTTP.h --- @@ -101,9 +105,9 @@ class InvokeHTTP : public core::Processor { static core::Relationship RelNoRetry; static core::Relationship RelFailure; - void onTrigger(core::ProcessContext *context, core::ProcessSession *session); - void initialize(); - void onSchedule(core::ProcessContext *context, core::ProcessSessionFactory *sessionFactory); + virtual void onTrigger(core::ProcessContext *context, core::ProcessSession *session); + virtual void initialize(); + virtual void onSchedule(core::ProcessContext *context, core::ProcessSessionFactory *sessionFactory); --- End diff -- Probably want to use override instead of virtual. > Begin building controlling API to facilitate control of agents > -------------------------------------------------------------- > > Key: MINIFI-339 > URL: https://issues.apache.org/jira/browse/MINIFI-339 > Project: Apache NiFi MiNiFi > Issue Type: New Feature > Components: C++ > Reporter: marco polo > Assignee: marco polo > Priority: Critical > Labels: Durability, Reliability, Statistics > > Begin building the controlling API in MiNiFi C++. This API will evolve and > likely have public and private elements. As development progresses we may > want more capabilities. > What I want to create as a straw man will be basic control and metrics > gathering > -- Start > -- Stop > -- Pause > -- Gather metrics > ** Throughput of of flow components > ** Execution time ( run time minus sleep time ) > ** Memory consumption > -- Drain repositories > -- Switch repository types. > Better employ update listener within this controlling API -- This message was sent by Atlassian JIRA (v6.4.14#64029)