This is an automated email from the ASF dual-hosted git repository.
lzljs3620320 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/paimon.git
The following commit(s) were added to refs/heads/master by this push:
new f3333cd8ea [rest] Remove useless CreateDatabaseResponse (#5318)
f3333cd8ea is described below
commit f3333cd8ea98133331f0d870e57f031be29cd420
Author: Jingsong Lee <[email protected]>
AuthorDate: Thu Mar 20 13:50:20 2025 +0800
[rest] Remove useless CreateDatabaseResponse (#5318)
---
.../src/main/java/org/apache/paimon/rest/RESTCatalog.java | 7 +------
.../test/java/org/apache/paimon/rest/MockRESTMessage.java | 7 -------
.../java/org/apache/paimon/rest/RESTCatalogServer.java | 5 +----
.../java/org/apache/paimon/rest/RESTObjectMapperTest.java | 12 ------------
paimon-open-api/rest-catalog-open-api.yaml | 8 +-------
.../org/apache/paimon/open/api/RESTCatalogController.java | 14 +++-----------
6 files changed, 6 insertions(+), 47 deletions(-)
diff --git a/paimon-core/src/main/java/org/apache/paimon/rest/RESTCatalog.java
b/paimon-core/src/main/java/org/apache/paimon/rest/RESTCatalog.java
index e37e85688c..a266808bed 100644
--- a/paimon-core/src/main/java/org/apache/paimon/rest/RESTCatalog.java
+++ b/paimon-core/src/main/java/org/apache/paimon/rest/RESTCatalog.java
@@ -55,7 +55,6 @@ import org.apache.paimon.rest.requests.RenameTableRequest;
import org.apache.paimon.rest.responses.AlterDatabaseResponse;
import org.apache.paimon.rest.responses.CommitTableResponse;
import org.apache.paimon.rest.responses.ConfigResponse;
-import org.apache.paimon.rest.responses.CreateDatabaseResponse;
import org.apache.paimon.rest.responses.ErrorResponseResourceType;
import org.apache.paimon.rest.responses.GetDatabaseResponse;
import org.apache.paimon.rest.responses.GetTableResponse;
@@ -207,11 +206,7 @@ public class RESTCatalog implements Catalog {
checkNotSystemDatabase(name);
CreateDatabaseRequest request = new CreateDatabaseRequest(name,
properties);
try {
- client.post(
- resourcePaths.databases(),
- request,
- CreateDatabaseResponse.class,
- restAuthFunction);
+ client.post(resourcePaths.databases(), request, restAuthFunction);
} catch (AlreadyExistsException e) {
if (!ignoreIfExists) {
throw new DatabaseAlreadyExistException(name);
diff --git
a/paimon-core/src/test/java/org/apache/paimon/rest/MockRESTMessage.java
b/paimon-core/src/test/java/org/apache/paimon/rest/MockRESTMessage.java
index 3c099f7372..a07c13d0df 100644
--- a/paimon-core/src/test/java/org/apache/paimon/rest/MockRESTMessage.java
+++ b/paimon-core/src/test/java/org/apache/paimon/rest/MockRESTMessage.java
@@ -27,7 +27,6 @@ import org.apache.paimon.rest.requests.CreateTableRequest;
import org.apache.paimon.rest.requests.CreateViewRequest;
import org.apache.paimon.rest.requests.RenameTableRequest;
import org.apache.paimon.rest.responses.AlterDatabaseResponse;
-import org.apache.paimon.rest.responses.CreateDatabaseResponse;
import org.apache.paimon.rest.responses.GetDatabaseResponse;
import org.apache.paimon.rest.responses.GetTableResponse;
import org.apache.paimon.rest.responses.GetTableTokenResponse;
@@ -72,12 +71,6 @@ public class MockRESTMessage {
return new CreateDatabaseRequest(name, options);
}
- public static CreateDatabaseResponse createDatabaseResponse(String name) {
- Map<String, String> options = new HashMap<>();
- options.put("a", "b");
- return new CreateDatabaseResponse(name, options);
- }
-
public static GetDatabaseResponse getDatabaseResponse(String name) {
Map<String, String> options = new HashMap<>();
options.put("a", "b");
diff --git
a/paimon-core/src/test/java/org/apache/paimon/rest/RESTCatalogServer.java
b/paimon-core/src/test/java/org/apache/paimon/rest/RESTCatalogServer.java
index e151f976c5..a57ba35e4d 100644
--- a/paimon-core/src/test/java/org/apache/paimon/rest/RESTCatalogServer.java
+++ b/paimon-core/src/test/java/org/apache/paimon/rest/RESTCatalogServer.java
@@ -52,7 +52,6 @@ import org.apache.paimon.rest.requests.RenameTableRequest;
import org.apache.paimon.rest.responses.AlterDatabaseResponse;
import org.apache.paimon.rest.responses.CommitTableResponse;
import org.apache.paimon.rest.responses.ConfigResponse;
-import org.apache.paimon.rest.responses.CreateDatabaseResponse;
import org.apache.paimon.rest.responses.ErrorResponse;
import org.apache.paimon.rest.responses.ErrorResponseResourceType;
import org.apache.paimon.rest.responses.GetDatabaseResponse;
@@ -571,7 +570,6 @@ public class RESTCatalogServer {
private MockResponse databasesApiHandler(
String method, String data, Map<String, String> parameters) throws
Exception {
- RESTResponse response;
switch (method) {
case "GET":
List<String> databases = new
ArrayList<>(databaseStore.keySet());
@@ -586,8 +584,7 @@ public class RESTCatalogServer {
catalog.createDatabase(databaseName, false);
databaseStore.put(
databaseName, Database.of(databaseName,
requestBody.getOptions(), null));
- response = new CreateDatabaseResponse(databaseName,
requestBody.getOptions());
- return mockResponse(response, 200);
+ return new MockResponse().setResponseCode(200);
default:
return new MockResponse().setResponseCode(404);
}
diff --git
a/paimon-core/src/test/java/org/apache/paimon/rest/RESTObjectMapperTest.java
b/paimon-core/src/test/java/org/apache/paimon/rest/RESTObjectMapperTest.java
index 02e41c8e52..017eb306d3 100644
--- a/paimon-core/src/test/java/org/apache/paimon/rest/RESTObjectMapperTest.java
+++ b/paimon-core/src/test/java/org/apache/paimon/rest/RESTObjectMapperTest.java
@@ -26,7 +26,6 @@ import org.apache.paimon.rest.requests.CreateViewRequest;
import org.apache.paimon.rest.requests.RenameTableRequest;
import org.apache.paimon.rest.responses.AlterDatabaseResponse;
import org.apache.paimon.rest.responses.ConfigResponse;
-import org.apache.paimon.rest.responses.CreateDatabaseResponse;
import org.apache.paimon.rest.responses.ErrorResponse;
import org.apache.paimon.rest.responses.GetDatabaseResponse;
import org.apache.paimon.rest.responses.GetTableResponse;
@@ -84,17 +83,6 @@ public class RESTObjectMapperTest {
assertEquals(request.getOptions().size(),
parseData.getOptions().size());
}
- @Test
- public void createDatabaseResponseParseTest() throws Exception {
- String name = MockRESTMessage.databaseName();
- CreateDatabaseResponse response =
MockRESTMessage.createDatabaseResponse(name);
- String responseStr = OBJECT_MAPPER.writeValueAsString(response);
- CreateDatabaseResponse parseData =
- OBJECT_MAPPER.readValue(responseStr,
CreateDatabaseResponse.class);
- assertEquals(name, parseData.getName());
- assertEquals(response.getOptions().size(),
parseData.getOptions().size());
- }
-
@Test
public void getDatabaseResponseParseTest() throws Exception {
String name = MockRESTMessage.databaseName();
diff --git a/paimon-open-api/rest-catalog-open-api.yaml
b/paimon-open-api/rest-catalog-open-api.yaml
index dff9053e4e..be0c262234 100644
--- a/paimon-open-api/rest-catalog-open-api.yaml
+++ b/paimon-open-api/rest-catalog-open-api.yaml
@@ -234,11 +234,7 @@ paths:
$ref: '#/components/schemas/CreateDatabaseRequest'
responses:
"200":
- description: OK
- content:
- application/json:
- schema:
- $ref: '#/components/schemas/CreateDatabaseResponse'
+ description: Success, no content
"409":
description: Resource has exist
content:
@@ -1430,8 +1426,6 @@ components:
format: int64
schema:
$ref: '#/components/schemas/Schema'
- uuid:
- type: string
owner:
type: string
createdAt:
diff --git
a/paimon-open-api/src/main/java/org/apache/paimon/open/api/RESTCatalogController.java
b/paimon-open-api/src/main/java/org/apache/paimon/open/api/RESTCatalogController.java
index faaa260bdd..d62a01380e 100644
---
a/paimon-open-api/src/main/java/org/apache/paimon/open/api/RESTCatalogController.java
+++
b/paimon-open-api/src/main/java/org/apache/paimon/open/api/RESTCatalogController.java
@@ -32,7 +32,6 @@ import org.apache.paimon.rest.requests.RenameTableRequest;
import org.apache.paimon.rest.responses.AlterDatabaseResponse;
import org.apache.paimon.rest.responses.CommitTableResponse;
import org.apache.paimon.rest.responses.ConfigResponse;
-import org.apache.paimon.rest.responses.CreateDatabaseResponse;
import org.apache.paimon.rest.responses.ErrorResponse;
import org.apache.paimon.rest.responses.GetDatabaseResponse;
import org.apache.paimon.rest.responses.GetTableResponse;
@@ -125,11 +124,7 @@ public class RESTCatalogController {
summary = "Create Databases",
tags = {"database"})
@ApiResponses({
- @ApiResponse(
- responseCode = "200",
- content = {
- @Content(schema = @Schema(implementation =
CreateDatabaseResponse.class))
- }),
+ @ApiResponse(responseCode = "200", description = "Success, no
content"),
@ApiResponse(
responseCode = "409",
description = "Resource has exist",
@@ -139,11 +134,8 @@ public class RESTCatalogController {
content = {@Content(schema = @Schema())})
})
@PostMapping("/v1/{prefix}/databases")
- public CreateDatabaseResponse createDatabases(
- @PathVariable String prefix, @RequestBody CreateDatabaseRequest
request) {
- Map<String, String> properties = new HashMap<>();
- return new CreateDatabaseResponse("name", properties);
- }
+ public void createDatabases(
+ @PathVariable String prefix, @RequestBody CreateDatabaseRequest
request) {}
@Operation(
summary = "Get Database",
